Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version strings for experimental branch. #70664

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Jan 5, 2024

Summary

None

Purpose of change

Several version strings in the game are still set to 0.F; I am actually still trying to find the one that is being used to call the game 0.G. I can't run the game at work, can someone sanity check that the splash screen is actually calling the game 0.G?

Describe the solution

This sets the version numbers to 0.I for the experimental branch. The stable 0.H branch has a parallel PR setting its own nubmers.

Testing

I'm at work and can't run the game, but I don't expect these will have much effect, except possibly on the splash version screen if that's currently calling the game 0.F

Additional context

It seems the splash screen isn't displaying a version letter at all currently, and I'm not sure if that's correct. It really should say either "0.H Stable" or "O.I experimental" depending on which branch you're on, and I'm not sure we need fancy code to determine that. It can probably just be directly entered into the menu cpp as a string...

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Jan 5, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 5, 2024
@Maleclypse Maleclypse merged commit 7b2ac96 into CleverRaven:master Jan 9, 2024
23 of 26 checks passed
@I-am-Erk I-am-Erk deleted the I-version branch January 10, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants