-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratkin lab fixes #70520
Merged
Merged
Ratkin lab fixes #70520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
labels
Dec 30, 2023
data/json/mapgen/microlab/microlab_distorted/microlab_distorted.json
Outdated
Show resolved
Hide resolved
data/json/mapgen/microlab/microlab_distorted/microlab_distorted_hallway.json
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Dec 30, 2023
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Dec 30, 2023
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
labels
Dec 30, 2023
…sm-DDA into RatkinLabFixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @LyleSY
Procyonae
force-pushed
the
RatkinLabFixes
branch
from
December 30, 2023 20:54
c1b37cc
to
1fd0b5f
Compare
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes ratkin labs having rock borders
Describe the solution
Replaces microlab_rock_border with special_rock, special_deep_rock and special_earth as appropriate
Migrates microlab_rock_border to special_rock
Adds a new entrance for the ratkin lab that sticks out less
Changes the ratkin overmap symbols and the entrance name to better match the sewers
Describe alternatives you've considered
I'm not sure ratkin labs should be able to be the flesh/root runner variants but who knows
Testing
Checked spawns of ratkin lab and other labs that were using microlab_rock_border
Additional context