Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratkin lab fixes #70520

Merged
merged 8 commits into from
Dec 31, 2023
Merged

Ratkin lab fixes #70520

merged 8 commits into from
Dec 31, 2023

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Dec 30, 2023

Summary

None

Purpose of change

Fixes ratkin labs having rock borders

Describe the solution

Replaces microlab_rock_border with special_rock, special_deep_rock and special_earth as appropriate
Migrates microlab_rock_border to special_rock
Adds a new entrance for the ratkin lab that sticks out less
image
Changes the ratkin overmap symbols and the entrance name to better match the sewers
image

Describe alternatives you've considered

I'm not sure ratkin labs should be able to be the flesh/root runner variants but who knows

Testing

Checked spawns of ratkin lab and other labs that were using microlab_rock_border

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Dec 30, 2023
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 30, 2023
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 30, 2023
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) labels Dec 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 30, 2023
@Maleclypse Maleclypse merged commit 180845b into CleverRaven:master Dec 31, 2023
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants