-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Power learning revamp: Biokinesis #70305
Merged
Fris0uman
merged 23 commits into
CleverRaven:master
from
Standing-Storm:learning-revamp-bio
Dec 27, 2023
Merged
[MoM] Power learning revamp: Biokinesis #70305
Fris0uman
merged 23 commits into
CleverRaven:master
from
Standing-Storm:learning-revamp-bio
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fungamer2-2
reviewed
Dec 19, 2023
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
This was referenced Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Documentation>
Design documents, internal info, guides and help.
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Power learning revamp: Biokinesis"
Purpose of change
The learn_spells field works well enough, but it doesn't allow for multiple prerequisites, and having powers suddenly pop into your mind unbidden is a little weird. Psionics is about self-discovery and exploring the power of the mind, after all.
This also allows for an easier and more logical path to very low difficulty powers--they might not have any prerequisites, but you need to think about it a bit before you can figure out how to do them.
Describe the solution
Completely rework the power learning system. Eliminate the learn_spells field entirely and set up a series of EoCs that check various prerequisites. Rework the contemplation recipes so that a beginning psion only starts with contemplation recipes for the powers they start with, and the EoCs will teach them new ones if they meet the prerequisites. Using a contemplation recipe when you don't know a power has a chance (based on a metaphysics roll vs power Difficulty + 4, +1 if you have a proficiency you’ll get from biokinetic contemplation) to teach you that power after a much longer period of contemplation.
Learning new powers is handled by a vitamin that is regained at a random interval (anywhere from 12 to 168 hours). You're only eligible for the power learning EoCs if you have that vitamin.
(I originally thought about increasing a vitamin based on powers used, but I definitely shouldn't incentivize staying in your base and setting up a macro to spam powers any more than the game already does)
While you generally need to know the prerequisites, there is a small chance (5% for Difficulty 1-3 powers, 2.5% for Difficulty 4-6 powers, and 1.25% for Difficulty 7+ powers) that you’ll have an enlightening flash of insight and unlock contemplation for a power without knowing the prerequisites. While you can’t rely on this for progression in any given game, if you play enough you have games where your starter pyrokinetic looks up from scarfing down lard in a ruined evac shelter and thinks, >>you know, I bet I could instantly incinerate people if I put my mind to it.<<
As part of this, remove all power XP limits on contemplation. Also as part of this, make a document to list what all powers are and what their prerequisites are.
I’ll also need to write some one-time EoC to handle migration to the new system, to remove the contemplation recipes for powers that people don’t know so they’ll be eligible for the discovery process.
Describe alternatives you've considered
Testing
EoC successfully migrates existing powers and removes unknown recipes.
(Spelling already fixed)
Started new game, waited a week to make sure the learning EoCs all deactivated, then used a biokinetic matrix crystal and waited another week to make sure they turned on again. They do:
Set both starting powers to 12 to make sure a new power option showed up, then attempted to learn it. Stopping contemplation in the middle does not lead to a new power learned. Success is possible:
Failure is also possible. Unlikely if you go in order, but if you have a flash of insight and try a higher-level contemplation it's harder:
![image](https://private-user-images.githubusercontent.com/120433252/293063952-88923cab-9e12-4cc9-9902-02e85b1acd9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzAzNjcsIm5iZiI6MTczOTMzMDA2NywicGF0aCI6Ii8xMjA0MzMyNTIvMjkzMDYzOTUyLTg4OTIzY2FiLTllMTItNGNjOS05OTAyLTAyZTg1YjFhY2Q5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwMzE0MjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iN2MzMWYyMTEzYjc3ZTBjNzA3MDk0OTM0YzQ5ZGJhZTA4ODVjOWU3Y2YxMWM1ZjE0NDA2MjY4ZTYzNzQ3ODgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.d6ZRttPYgLZ4tDq5jxOaUEzFgvrufdOT1MnY93bGsyw)
Additional context
It's going to be a separate PR for each path to avoid massive PR length.
Also trying to get some work done on this on my phone, during down time while visiting family, is a nightmare.