Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Power learning revamp: Biokinesis #70305

Merged
merged 23 commits into from
Dec 27, 2023

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 19, 2023

Summary

Mods "[MoM] Power learning revamp: Biokinesis"

Purpose of change

The learn_spells field works well enough, but it doesn't allow for multiple prerequisites, and having powers suddenly pop into your mind unbidden is a little weird. Psionics is about self-discovery and exploring the power of the mind, after all.

This also allows for an easier and more logical path to very low difficulty powers--they might not have any prerequisites, but you need to think about it a bit before you can figure out how to do them.

Describe the solution

Completely rework the power learning system. Eliminate the learn_spells field entirely and set up a series of EoCs that check various prerequisites. Rework the contemplation recipes so that a beginning psion only starts with contemplation recipes for the powers they start with, and the EoCs will teach them new ones if they meet the prerequisites. Using a contemplation recipe when you don't know a power has a chance (based on a metaphysics roll vs power Difficulty + 4, +1 if you have a proficiency you’ll get from biokinetic contemplation) to teach you that power after a much longer period of contemplation.

Learning new powers is handled by a vitamin that is regained at a random interval (anywhere from 12 to 168 hours). You're only eligible for the power learning EoCs if you have that vitamin.

(I originally thought about increasing a vitamin based on powers used, but I definitely shouldn't incentivize staying in your base and setting up a macro to spam powers any more than the game already does)

While you generally need to know the prerequisites, there is a small chance (5% for Difficulty 1-3 powers, 2.5% for Difficulty 4-6 powers, and 1.25% for Difficulty 7+ powers) that you’ll have an enlightening flash of insight and unlock contemplation for a power without knowing the prerequisites. While you can’t rely on this for progression in any given game, if you play enough you have games where your starter pyrokinetic looks up from scarfing down lard in a ruined evac shelter and thinks, >>you know, I bet I could instantly incinerate people if I put my mind to it.<<

As part of this, remove all power XP limits on contemplation. Also as part of this, make a document to list what all powers are and what their prerequisites are.

I’ll also need to write some one-time EoC to handle migration to the new system, to remove the contemplation recipes for powers that people don’t know so they’ll be eligible for the discovery process.

Describe alternatives you've considered

Testing

EoC successfully migrates existing powers and removes unknown recipes.

image
(Spelling already fixed)

Started new game, waited a week to make sure the learning EoCs all deactivated, then used a biokinetic matrix crystal and waited another week to make sure they turned on again. They do:

image

Set both starting powers to 12 to make sure a new power option showed up, then attempted to learn it. Stopping contemplation in the middle does not lead to a new power learned. Success is possible:

image

Failure is also possible. Unlikely if you go in order, but if you have a flash of insight and try a higher-level contemplation it's harder:
image

Additional context

It's going to be a separate PR for each path to avoid massive PR length.

Also trying to get some work done on this on my phone, during down time while visiting family, is a nightmare.

@Standing-Storm Standing-Storm marked this pull request as draft December 19, 2023 17:03
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Dec 19, 2023
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 19, 2023
Standing-Storm and others added 2 commits December 19, 2023 11:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 19, 2023
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 19, 2023
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Dec 20, 2023
@github-actions github-actions bot added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label Dec 20, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 26, 2023
@Standing-Storm Standing-Storm marked this pull request as ready for review December 27, 2023 16:11
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Use of your powers has led to an insight. Combining enhancements to speed, strength, reaction time, agility, and coordination, you could enter a battle trance like the legendary berserkergang, but with full control over your mind, if you can figure out the technique.
  • Use of your powers has led to an insight. You could twist your joints and relax your muscles far beyond the capability of a baseline human, allowing you to escape shackles and adeptly dodge blows for a brief period, if you can figure out the proper technique.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Fris0uman Fris0uman merged commit a2fb350 into CleverRaven:master Dec 27, 2023
20 of 23 checks passed
@Standing-Storm Standing-Storm deleted the learning-revamp-bio branch December 28, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants