Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-game customization #70025

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

furran
Copy link
Contributor

@furran furran commented Dec 6, 2023

Summary

Bugfixes "Fix in-game customization when using hair trimmer, hand mirror, etc"

Purpose of change

Currently if the player uses a hand mirror, standing mirror or hair trimmer and picks a in-game customization option that implements variants, the variant will be randomized.

This fix makes it so the player is prompted to pick a variant for the selected trait instead (if it has them).

Closes #69944

Describe the solution

Altered the customize appearance function so you first select the trait and then you can select the variant for that trait (if it has variants).

Describe alternatives you've considered

Undoing variants for all cosmetic mutations that use them, but that felt like going backwards.

Testing

Get in game, spawn a hand mirror, select eye color and pick a color.

Additional context

This PR was split from #70017

 - Check if selected trait has variations when in a customization menu
 and if it does, show the variation menu to select a variation.
@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 6, 2023
@furran furran force-pushed the fix_customization branch from a0c85ae to dd09914 Compare December 6, 2023 20:28
@furran furran force-pushed the fix_customization branch from dd09914 to 85fc289 Compare December 6, 2023 22:27
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 6, 2023
@furran furran force-pushed the fix_customization branch from af456ce to 0b92f3c Compare December 7, 2023 00:04
@Standing-Storm
Copy link
Contributor

If it's not too much of a hassle, is there a possibility to link this customization into an effect that could be called by EoC? When I checked, the existing barber_hair and barber_beard only work in dialogue with an NPC and there's no way to customize skin or eye color through EoC at all.

@furran
Copy link
Contributor Author

furran commented Dec 7, 2023

@Standing-Storm hmm I think it would be out of scope of this PR since I am just making it so you have to pick a variant if you select a trait that has them, as opposed to have it randomized in the customization screen. Also, I haven't messed with EoCs at all yet. Really out of my depth there atm

@Maleclypse Maleclypse merged commit 433a11b into CleverRaven:master Dec 8, 2023
25 checks passed
@furran furran deleted the fix_customization branch December 8, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standing mirror changes eye color randomly
3 participants