un-variant eye color mutation

[KeremBabaG]

Summary

Bugfixes "fixes eye color mutation"

Purpose of change

Closes #69944. Eye color mutation for some reason was a single entry with multiple variants, which prevented people from changing to a specific eye color via mirrors or debug.

Describe the solution

Change eye colors to be 6 different mutations with different variants instead of one mutation with 6 variants, adjust npcs accordingly.

Describe alternatives you've considered

don't do this

Testing

the game gave a warning about eye_color being an invalid trait, but otherwise nothing else for now.

Additional context

[Vaskritaya]

I'm not convinced this is the best way of doing this. The hair variants have a similar problem in debug and with the haircut kit, and it would be terrible for maintenance and json cleanliness to decompose them like this too. Ideally, we'd have more robust handling of mutation variants in these kinds of uis.

It's not a huge issue for the handful of eye mutations though. Either way, just my two cents.

[worm-girl]

I'm not convinced this is the best way of doing this. The hair variants have a similar problem in debug and with the haircut kit, and it would be terrible for maintenance and json cleanliness to decompose them like this too. Ideally, we'd have more robust handling of mutation variants in these kinds of uis.

It's not a huge issue for the handful of eye mutations though. Either way, just my two cents.

I do think the whole thing could be done better. Maybe what we need is a better and more consistent way in code to swap between variants. This would also let us add hair dye.

I think this should be closed and #70017 should be the model we work from.

[KeremBabaG]

kk closed