Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Maintained spell message grammar improvements #69578

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

b3brodie
Copy link
Contributor

@b3brodie b3brodie commented Nov 20, 2023

Summary

None

Purpose of change

"Grammar / wording improvements for maintained spells" There was a couple of grammar issues I saw with the karma arms maintain message in game that I see frequently, so I gave the whole file a parse through.

Describe the solution

Fixes some grammar issues and aims for present tense in the messages. One or two other slight wording changes that I feel work better.

Describe alternatives you've considered

N/A

Testing

N/A

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Nov 20, 2023
@github-actions github-actions bot requested a review from Maleclypse November 20, 2023 07:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 20, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 20, 2023
@Maleclypse Maleclypse merged commit 6807388 into CleverRaven:master Nov 20, 2023
@b3brodie b3brodie deleted the xedra_wording branch November 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants