Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ar rifles inheritance #69394

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix ar rifles inheritance #69394

merged 1 commit into from
Nov 15, 2023

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Fix #68806

Describe the solution

Add some inheritance to ar guns, remove inheritances the game yell as duplicative

Describe alternatives you've considered

I suppose there is a ton of place to simplify or inherit stuff one from another, or like straight obsolete some guns in favor of variants with properly defined gunmods, but tbh guns are such a mess i'm a bit afraid to touch it for myself

Testing

Game loads, ar guns still shoot

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 14, 2023
@Maleclypse Maleclypse merged commit 7bfd353 into CleverRaven:master Nov 15, 2023
@GuardianDll GuardianDll deleted the #68806 branch November 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AR guns are missing reload_noise_volume, etc
2 participants