Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Merge lasers and photokinetic damage #69366

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[MoM] Merge lasers and photokinetic damage"

Purpose of change

Since Photokinetic attack powers essentially shoot lasers at people, lasers might as well do photokinetic damage so they can interact.

Describe the solution

Change the laser weapons to do photokinetic damage and rename the damage type "focused light."

Describe alternatives you've considered

Testing

Spawned a feral beacon and shot it a bunch of times with a laser pistol. No effect.

Additional context

I think the Hub turrets are the only base-game laser shooting enemy, and I edited their fake gun.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 14, 2023
@Maleclypse
Copy link
Member

Love this!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 14, 2023
@RAldrich
Copy link
Contributor

Not a blocking concern (so maybe I should open an issue instead of discussing it here), but why do lasers (regardless of source) need a new damage type? My understanding is that IRL lasers cause burns, or in cases where power output is high enough, wounds that are quite similar to gunshots.

The basic mechanism is flash vaporization of whatever is at the impact site (mostly water, in a biologist target) leads to a concussion wave. You can actually manipulate how much "heating" vs "explosion" you get through various wavelength manipulations.

An academic source:

https://apps.dtic.mil/sti/citations/ADA476965

@Maleclypse
Copy link
Member

Maleclypse commented Nov 14, 2023

Not a blocking concern (so maybe I should open an issue instead of discussing it here), but why do lasers (regardless of source) need a new damage type? My understanding is that IRL lasers cause burns, or in cases where power output is high enough, wounds that are quite similar to gunshots.

The basic mechanism is flash vaporization of whatever is at the impact site (mostly water, in a biologist target) leads to a concussion wave. You can actually manipulate how much "heating" vs "explosion" you get through various wavelength manipulations.

An academic source:

https://apps.dtic.mil/sti/citations/ADA476965

Because this is for Mind over Matter the psychic mod. And if you have one group of psychics who control heat and fire and one that controls light and lasers, you need to divide heat and laser damage or else there is weird overlap

Edit: your citation would be excellent if this were about vanilla DDA. I'm not sure that it matters so much in a mod.

@Standing-Storm
Copy link
Contributor Author

As well, photokinetic damage is derived from heat damage and laser weapons still have the INCENDIARY flag on their ammo, so there's no physics violation in this part of the psionic powers mod.

@Maleclypse Maleclypse merged commit 72d4bd6 into CleverRaven:master Nov 14, 2023
@Standing-Storm Standing-Storm deleted the laser-damage branch November 14, 2023 22:42
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
* Initial commit

* change photokinetic damage verbs

* Add laser turret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants