Correct closing brackets in COMPILING-VS-VCPKG.md guide #69288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
|
Whups my bad. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I followed the instructions for compiling and installed LLVM via github. In the process I found that the closing brackets on the documentation for installation were incorrect (maybe? I asked and someone nice verified this). The closing bracket text didn't match the opening bracket text.
Describe the solution
Applied correct bracket text.
Describe alternatives you've considered
Letting someone who wouldn't accidently set fire to CDDA do this.
Testing
VS Studio stopped yelling at me when I cleaned the solution and let me build with the new corrected Directory.Build.props file.
Additional context
If I set fire to CDDA on accident I'm very sorry and promise not to do it again.