Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You load 59 typos what do you get? #69272

Merged

Conversation

sadenar
Copy link
Contributor

@sadenar sadenar commented Nov 11, 2023

Summary

Content "Miscellaneous typo, inconsistencies, punctuation errors, pluralization errors... fixes"

Purpose of change

While translating I get exposed to a lot of issues that nobody else usually comes across so I write them down and make a big issue or PR every once and a while, this is one of those.

Describe the solution

For this one the fixes were mostly awkward plurals, capitalizations, punctuations, or the lack of them, I've touched a lot of stuff, both mainline and across MoM, Magiclysm, Aftershock and XE. None of it should be that meaningful or disruptive. I also cleaned up after myself after I forgot to put a period at the end of one of the Autodoc wound sterilizing messages last big typo PR I did.

Describe alternatives you've considered

  • Make a big issue listing those instead of fixing them myself
  • Waiting until I got more, but I find quite a few while I was doing those I already had noted down, so 59 changes in my mind was enough

Testing

No testing yet, the changes were purely text, but will load the changes on my copy to check if the game screams at me.

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Lore Game lore, in-game communication. Also the Lore tab. Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Mind Over Matter labels Nov 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll @Standing-Storm

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 11, 2023
@KeremBabaG
Copy link
Contributor

the Turkish cookbook's description lacks a dot at the end, can you take a look at that as well?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 11, 2023
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • HEH, ye c'nnae get enough o' ol' Rubik's merchandise, eh? Sure as 'ell, come back in .
  • Why is there a distinction between pyrokinesis and telekinesis at all? Fire isn't a fundamental element, it's the result of heat which is the result of molecular motion. There's no conceptual reason why a pyrokinetic couldn't make all the molecules of an object move in a particular direction, producing motion of the entire object, or a telekinetic couldn't produce a more chaotic motion that resulted in the object's energy increasing. Furthermore, in no test has a telekinetic been able to move part of an object unless that part is designed for motion; pulling a lever is possible, but breaking a plate in half is not. And a pyrokinetic cannot apply the reverse and slow down an object's molecules to reduce heat unless that object is on fire.\n\nMy theory is that it's all psychological. We've all grown up with modern culture and stories about what psychics are "supposed" to be capable of, and so the matrix crystals and Netherum mathematics shape the candidates' abilities toward those pre-determined pathways. If we could get a SMOKE USHER mathematician from an uncontacted tribe, maybe they'd be able to induce diseases in their targets or steal or their soul, in accordance with that tribe's belief practices about supernatural powers. But since our candidates come from a culture where pyrokinesis and telekinesis are separate things and geokinesis or osteokinesis are very rare in fiction, the former result from awakenings and the latter do not.\n\nI would like to formally request a wider variety of cultural backgrounds for our project candidates to test this theory.
  • advanced heat exchangers
  • heat recuperators

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Maleclypse Maleclypse merged commit 0a3f4ca into CleverRaven:master Nov 12, 2023
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
* big ol' commit

* Small fix to alchemy stuff + Turkish cookbook fix + dictionary expansion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants