Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brigandine ALLOWS_TAIL adjustments #69267

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

actually-a-cat
Copy link
Contributor

Summary

Balance "Brigandine coat allows tail"

Purpose of change

Brigandine coat has only 85% hip coverage, it's both believable and not a balance issue if it can be worn by tailed characters. This will help somewhat with the dearth of hip armor options for them (obviously their options should be inferior compared to what someone with normal anatomy can wear, but there should be options. 85% is inferior enough.)

ALLOWS_TAIL on splint leg guards and greaves is redundant as those items don't have hip coverage, so they wouldn't conflict with tails anyway.

Describe the solution

Add ALLOWS_TAIL to brigandine coat, remove from greaves and leg guards.

Describe alternatives you've considered

I thought about splitting out the skirt/tasset part of the coat as a separate item but I don't see a way to make this work with the chainmail attachment system. If I added another pocket for the skirt there would be nothing preventing stacking them, and if I didn't the inability to wear it with chainmail would be glaring.

Testing

  • Verify coats can be worn with tail
  • Verify leg guards and greaves can still be worn with tail

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 11, 2023
@Maleclypse Maleclypse merged commit 512cc9f into CleverRaven:master Nov 11, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants