Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] change Inferno Grenade fuse #69218

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

Terrorforge
Copy link
Contributor

@Terrorforge Terrorforge commented Nov 9, 2023

Summary

Bugfixes "[MoM] change Inferno Grenade fuse and casing"

Purpose of change

The Inferno Grenade recipe uses the delayed fuze for its recipe. This doesn't make sense to me, because the delayed fuze is a complicated mechanical assembly that can only be acquired by disassembling military explosives, whereas the inferno grenade is clearly an improvised explosive made from duct tape and tin cans. Also, the delayed fuze says its purpose is to directly detonate stable explosives, but the inferno grenade uses volatile explosives to catalyze its psychic firestorm, much more akin to the way e.g. the homemade grenades use volatile explosives to catalyze stable explosives, and those use standard fuses.

e: also, inferno grenades are the size of small homemade grenades and drop empty canisters when used, so they should probably use the casings for small grenades rather than medium tin can in their recipe

Describe the solution

Change it to the standard "fuse" item.

e: change it to use the small_grenade_case list instead of medium tin can

Describe alternatives you've considered

I was gonna ask @Standing-Storm if this was intentional, but it's such a quick change it was easier to just make the PR and let them shoot it down if necessary.

Testing

Additional context

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter labels Nov 10, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 10, 2023
@Cupidatis
Copy link

Maybe also some alternatives for tin cans...

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 10, 2023
@Terrorforge
Copy link
Contributor Author

Oh right, I forgot about that. Inferno grenades are the size of small homemade grenades and drop "empty canister" when used, so they should probably use the small grenade casings in the the recipe rather than the medium tin can. I've now included that change as well

@Maleclypse Maleclypse merged commit 912b6f2 into CleverRaven:master Nov 12, 2023
@Terrorforge Terrorforge deleted the patch-7 branch November 12, 2023 17:56
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
* change Inferno Grenade fuse

* Update inferno grenade casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants