-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced mi-go weakpoint/proficiencies+mi-go harvest #69207
Conversation
Would it be too unreasonable that the player could look at the proficiency screen and see under Principles of Biology that it is a pre-req for mi-go biology? |
The only proficiency screen I'm aware of (apart from debug stuff) is the section on the character screen, and that section only lists proficiencies if you've gained enough knowledge to open the learning of it, which is exactly what the lack of prerequisits prevents. There may be a screen I'm not aware of, and it could also be considered to add proficiency to the character proficiency screen once your character knows about them (in which case you probably want a display filter, as it would get flooded rather quickly). I don't think it would be good to have prerequisites show dependent prerequisites unless the player knows about the dependent one (which might be when first fighting a mi-go, in this case, although there would also be something that would register the knowledge. Another drawback to showing dependent proficiencies on their prerequisites is that it's still not obvious that which proficiency you should look at, as the prerequisite proficiency might be a bit of a guess. |
to me, making it depend on the basic biology one could make sense, after all the mi-go 'lifeform' has to be earth-like enough to survive here. Also the Agree with the point that theres no mechanism to indicate prereqs of proficiencies, this seems like a issue in general for any proficiency that isn't obvious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some expansion. I like your snippets but I think there's a bit too much actual figuring out what the organs do, so I adjusted them to imply more that you found something important but aren't necessarily certain what it does.
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
…9207) * Introduced mi-go weakpoint/proficiencies+mi-go harvest * lint * Update data/json/materials.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/items/comestibles/carnivore.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/items/comestibles/carnivore.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/monster_weakpoints/migo_weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/monster_weakpoints/migo_weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/monster_weakpoints/migo_weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/monster_weakpoints/migo_weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/proficiencies/weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/proficiencies/weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/proficiencies/weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/proficiencies/weakpoints.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Update data/json/snippets/mi-go_anatomy.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com> * Snippet adjustment --------- Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Summary
None
Purpose of change
Describe the solution
Adding the corresponding entries and files. In the case of dissection it meant mi-go specific meat, blood, and bone, plus some snippets.
Describe alternatives you've considered
Testing
Additional context
This PR should probably be looked at by those in charge of the lore, since the snippets in particular, but also the harvesting products describe the anatomy of the critters to some extent.
Trying to override the nutrients of flesh didn't work, as iron was displayed for mi-go meat both with an empty vitamin line and with a vitamin line setting the two nutrients to 0.0 after the copy-didn't block the provision of iron. Setting it to inedible did (although it does not stop you from eating it). This probably means that calorie override became redundant, but I didn't remove it to check.