Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced mi-go weakpoint/proficiencies+mi-go harvest #69207

Merged
merged 25 commits into from
Nov 11, 2023

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

  • Introduce mi-go specific weakpoints and corresponding proficiencies.
  • Introduce mi-go specific dissection results and snippets.

Describe the solution

Adding the corresponding entries and files. In the case of dissection it meant mi-go specific meat, blood, and bone, plus some snippets.

Describe alternatives you've considered

  • Adding mi-go hide, but decided it should wait until there was a use for it.
  • Making the mi-go proficiencies dependent on at least the basic biology one, but decided not to as it doesn't make sense to learn normal biology from these weirdos, and there's no reasonable mechanism (known to me) to indicate to the player which proficiency the player would have to master to unblock it (you could use the unreasonable mechanism to have that in the proficiency name, but that is, well, unreasonable).
  • Usage of mi-go bone was considered out of scope for this PR (and really out of the scope of what the author would be comfortable with). The description indicates you probably can't find any use for it, so if someone does introduce usages, the description should be modified.

Testing

  • Spawned a mi-go and fought it to verify the mi-go basic biology proficiency appear in the character sheet.
  • Debug mastered that proficiency and verified the physiology proficiency appeared.
  • Fought mi-gos until a weakpoint message appeared (after having seen the natural armor one which was present before).
  • Implemented the harvesting stuff.
  • Spawned a mi-go, debug killed it and dissected it. Saw a dissection message and examined the products.

Additional context

This PR should probably be looked at by those in charge of the lore, since the snippets in particular, but also the harvesting products describe the anatomy of the critters to some extent.

Trying to override the nutrients of flesh didn't work, as iron was displayed for mi-go meat both with an empty vitamin line and with a vitamin line setting the two nutrients to 0.0 after the copy-didn't block the provision of iron. Setting it to inedible did (although it does not stop you from eating it). This probably means that calorie override became redundant, but I didn't remove it to check.

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Nov 9, 2023
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 9, 2023
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 9, 2023
@toweroglass
Copy link

Describe alternatives you've considered
Making the mi-go proficiencies dependent on at least the basic biology one, but decided not to as it doesn't make sense to learn normal biology from these weirdos, and there's no reasonable mechanism (known to me) to indicate to the player which proficiency the player would have to master to unblock it (you could use the unreasonable mechanism to have that in the proficiency name, but that is, well, unreasonable).

Would it be too unreasonable that the player could look at the proficiency screen and see under Principles of Biology that it is a pre-req for mi-go biology?
I get that a mi-go shouldn't teach you basic biology, but wouldn't understanding the basics of biology make you better equipped to understand a completely alien biology?

@PatrikLundell
Copy link
Contributor Author

The only proficiency screen I'm aware of (apart from debug stuff) is the section on the character screen, and that section only lists proficiencies if you've gained enough knowledge to open the learning of it, which is exactly what the lack of prerequisits prevents. There may be a screen I'm not aware of, and it could also be considered to add proficiency to the character proficiency screen once your character knows about them (in which case you probably want a display filter, as it would get flooded rather quickly).
I would prefer to have basic biology to be a prerequisite for mi-go knowledge, but only if the player can understand what's missing. It might also be possible to have the dissection screen show missing prerequisites if they are not among the ones learned.

I don't think it would be good to have prerequisites show dependent prerequisites unless the player knows about the dependent one (which might be when first fighting a mi-go, in this case, although there would also be something that would register the knowledge. Another drawback to showing dependent proficiencies on their prerequisites is that it's still not obvious that which proficiency you should look at, as the prerequisite proficiency might be a bit of a guess.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2023
@Bobtron
Copy link
Contributor

Bobtron commented Nov 10, 2023

Making the mi-go proficiencies dependent on at least the basic biology one, but decided not to as it doesn't make sense to learn normal biology from these weirdos, and there's no reasonable mechanism (known to me) to indicate to the player which proficiency the player would have to master to unblock it (you could use the unreasonable mechanism to have that in the proficiency name, but that is, well, unreasonable).

to me, making it depend on the basic biology one could make sense, after all the mi-go 'lifeform' has to be earth-like enough to survive here. Also the Principles of Biology is a prereq for a bunch of other monster biologies, like zombies, invertebre, etc, so adding it as a prereq for mi-go biology seems consistent. Could also make mi-go proficiencies dependent on Xenology, desc You are beginning to grasp a general idea of how alien and post-Cataclysm mutated creatures function and operate., but it could be locking this weakpoint proficiency behind too many layers.

Agree with the point that theres no mechanism to indicate prereqs of proficiencies, this seems like a issue in general for any proficiency that isn't obvious.

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some expansion. I like your snippets but I think there's a bit too much actual figuring out what the organs do, so I adjusted them to imply more that you found something important but aren't necessarily certain what it does.

data/json/materials.json Outdated Show resolved Hide resolved
data/json/items/comestibles/carnivore.json Outdated Show resolved Hide resolved
data/json/items/comestibles/carnivore.json Outdated Show resolved Hide resolved
data/json/items/comestibles/carnivore.json Outdated Show resolved Hide resolved
data/json/monster_weakpoints/migo_weakpoints.json Outdated Show resolved Hide resolved
data/json/snippets/mi-go_anatomy.json Outdated Show resolved Hide resolved
data/json/snippets/mi-go_anatomy.json Outdated Show resolved Hide resolved
data/json/snippets/mi-go_anatomy.json Outdated Show resolved Hide resolved
data/json/snippets/mi-go_anatomy.json Outdated Show resolved Hide resolved
data/json/snippets/mi-go_anatomy.json Outdated Show resolved Hide resolved
PatrikLundell and others added 19 commits November 10, 2023 20:49
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
PatrikLundell and others added 2 commits November 10, 2023 21:08
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Something that looks like it fills a role similar to blood vessels, assuming the pink ichor is in fact blood, form a central plexus that doesn't make much sense to you. It's impossibly complex, a tiny road map of shockingly tough tubules in a pattern that almost looks like it spells a word in some unknowable language.
  • You note that the ichorous blood of this creature is unlike any similar stuff you've ever encountered or even heard of. It's not only the odd color - pink like pepto bismol - but also its texture. Somehow it is both oily and sticky, and the viscosity seems to change as you work with it.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

PatrikLundell and others added 2 commits November 10, 2023 21:09
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
@I-am-Erk I-am-Erk merged commit f1521a8 into CleverRaven:master Nov 11, 2023
@PatrikLundell PatrikLundell deleted the mi-go_prof branch November 11, 2023 06:34
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
…9207)

* Introduced mi-go weakpoint/proficiencies+mi-go harvest

* lint

* Update data/json/materials.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/items/comestibles/carnivore.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/items/comestibles/carnivore.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/monster_weakpoints/migo_weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/monster_weakpoints/migo_weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/monster_weakpoints/migo_weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/monster_weakpoints/migo_weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/proficiencies/weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/proficiencies/weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/proficiencies/weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/proficiencies/weakpoints.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Update data/json/snippets/mi-go_anatomy.json

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

* Snippet adjustment

---------

Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants