CDDA is about to E.X.P.L.O.D.E. (EOD stuff) #69063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenmillimaster
changed the title
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
astyled
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
harakka
requested changes
Nov 11, 2023
Co-authored-by: Antti Riikonen <harava@gmail.com>
github-actions
bot
added
the
BasicBuildPassed
Maleclypse
pushed a commit
to Maleclypse/Cataclysm-DDA
that referenced
this pull request
Nov 16, 2023
* Everything EOD. I hope. * eod2 - these stupid deltoid plates * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Descriptions. * Update data/json/items/armor/ballistic_armor.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * accidentally some plates * Update professions.json * Update data/json/items/armor/legs_armor.json Co-authored-by: Antti Riikonen <harava@gmail.com> * Update boots.json * appease density test --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> Co-authored-by: Antti Riikonen <harava@gmail.com>
|
nice to see these get some love, would be interesting to add some recipes for custom up armoring them in a similar branch to survivor gear, just heavier and more encumbering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "EOD suit adjustments and EOD paraphernalia"
Purpose of change
EOD suits were previously providing considerable ballistic protection, all over the body. This would not be accurate; EOD suits are primarily meant to protect from blast and fragmentation on approach, not bullets.
Describe the solution
I changed the material type of the EOD suits and scaled their protection to values that might give some protection to very weak bullets, but nothing more. I added a central plate pocket to both the EOD suit and the light EOD suit (renamed to tactical EOD suit to better reflect usage) that offered some more ballistic protection as a side effect of design.
Along the way I also adjusted price (https://online.ogs.ny.gov/purchase/spg/awards/3823223173Can.htm) , added some paraphernalia to the EOD spawns, And also added LVL III deltoid plates that the tactical eod suit could accept.
ALSO added spots in police dept mapgen where cop_armory wasn't spawning.
Describe alternatives you've considered
Making the tactical EOD suit as modular as it's supposed to be - there's like a kajillion pieces.
Adding a flag for deltoid plates instead of limiting what can be put in the deltoid pockets via item length.
Not adding these stupid plates.
Adding a gorget/mega collar to the EOD suit, but I ran into issues doing that. See issue #69049 .
I think also we need a separate overpressure damage type for concussions. Or otherwise just have explosives deal bash damage.
Testing
Loaded game, spawned items, checked spawns. Tossed some grenades to 5 tiles away - at the cusp of the kill radius - and didn't die sometimes, which is about what I'd expect of an EOD suit. Tried putting plates in and out.
Additional context
While it wasn't terribly helpful I did use https://www.youtube.com/watch?v=s3pTJ1dIvMg as a source of some information, primarily plate composition.