-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decrease frequency of tileset updates #67499
Conversation
tileset development activity is sorta low at the moment, I'd be making stuff up if I started presenting numbers, but I think reducing the frequency of the update PRs would be OK if anyone wants weekly updates, they are available at the upstream repositories this now runs once a month
I'm ok with merging this if frequent updatess causing issues but if the only issue is one PR a week I'm not sure that's an issue? |
let's see, this is not about fixing a problem, it's more about tweaking the balance between sprites added and the regularity of the updates -- currently the balance is towards regular updates, not sprites added; now the updates consist of a few sprites and lots of script generated json modifications (the script really likes to move json around) this akin to making lots of small PRs instead of a big one, my motivation is to make the update PRs less bare |
i dont think its an issue and affects anything |
On discord this morning We are far outside of my realm of expertise here |
CC sounds has the particular position of not partaking in the repo's data beforehand at all and being massive adapting the model of cc sounds means removing all tilesets that are being worked on, cause why keep them if they will be outdated, leaving only tynitile in the repo downloading tilesets (from upstream or a packed release) because the repo no longer contains the main ones and setting git ignores for the ones I use is not convenient, updating occasionally was the working method for a long time, I automated the updates to help fris, I want to tweak the rate of updates, again the updates come along every week and are small content-wise |
I really think this was objectively a bad PR to add into experimental. It makes no sense, unless the action of merging sprites is a lot of work. For example new sprites were merged December 1st, and a bunch of new sprites were uploaded less than a day after. But we have to wait an entire month for those to appear in a daily updated, open source experimental game? Maybe sprite development is slow enough to warrant it, but personally I miss seeing the weekly ruleset updates, and the monthly thing has yet to feel any better. |
Summary
None
Purpose of change
tileset development activity is sorta low at the moment, I'd be making stuff up if I started presenting numbers, but I think reducing the frequency of the update PRs would be OK
if anyone wants weekly updates, they are available at the upstream repositories
this now runs once a month
Describe the solution
Describe alternatives you've considered
Testing
Additional context