Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added detailed info on stats on character creation menu #67346

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Added detailed info on stats on character creation menu #67346

merged 3 commits into from
Aug 1, 2023

Conversation

Night-Pryanik
Copy link
Contributor

@Night-Pryanik Night-Pryanik commented Aug 1, 2023 •
edited
Loading

Summary

Interface "Detailed information for stats on character creation menu"

Purpose of change

More info allows less experienced players to meaningfully choose stats when creating their characters.

Describe the solution

Ported Cataclysm-TISH-team#70.

Describe alternatives you've considered

None.

Testing

Started creating character, switched to STATS tab, looked on the screen.

Additional context

изображение

изображение

изображение

изображение

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 1, 2023
@Night-Pryanik Night-Pryanik removed the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 1, 2023
ZhilkinSerg
ZhilkinSerg reviewed Aug 1, 2023
View reviewed changes
src/newcharacter.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 1, 2023
@Night-Pryanik Night-Pryanik removed the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 1, 2023
@alp7292
Copy link
Contributor

alp7292 commented Aug 1, 2023

intellegance makes you learn skills faster

@Night-Pryanik
Copy link
Contributor Author

I wonder why Move cost while swimming values are different on Strength and Dexterity pics despite they both reference to the same swim_speed function.

Night-Pryanik
Night-Pryanik commented Aug 1, 2023
View reviewed changes
src/newcharacter.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 1, 2023
@Night-Pryanik Night-Pryanik removed the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 1, 2023
@Maleclypse Maleclypse merged commit 5f9b42d into CleverRaven:master Aug 1, 2023
@teapot156
Copy link

YEAH

@Night-Pryanik Night-Pryanik deleted the detailed-stats branch August 2, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhilkinSerg ZhilkinSerg ZhilkinSerg left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add actual effects of stats to the stats screen for character creation
5 participants
@Night-Pryanik @alp7292 @teapot156 @ZhilkinSerg @Maleclypse