Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear tile map memory on part removal #66775

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jul 9, 2023

Summary

None

Purpose of change

Fixes #66747

Describe the solution

Clear tile map memory when part on tile gets removed and the memorized decoration string starts with the displayed part id.

Not a perfect solution, for example removing a board, or whatever currently displayed part is but not the last one on tile, makes the vehicle parts on tile disappear until player gains sight on the tile.

Describe alternatives you've considered

Could put fd_clairvoyant on the tile if part is removed by a character activity, but the field is buggy and seems to randomly not work at all (or i somehow didn't apply it right)

Testing

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 9, 2023
@dseguin dseguin merged commit 20a0875 into CleverRaven:master Jul 10, 2023
@irwiss irwiss deleted the clear-memory-on-part-removal branch July 10, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some removed vehicle parts still appear in the map memory
2 participants