Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mod tracker for vpart_info #66526

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jun 29, 2023

Summary

None

Purpose of change

Check for duplicate vpart definition ids

Describe the solution

Enable mod_tracker

Remove some duplicate vpart defs, they were moved to doors.json and accidentally resurrected in #61087, mod_tracker will now raise errors for this

Remove LOCKABLE_DOOR from cloth doors

Describe alternatives you've considered

Testing

Tests should pass

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 29, 2023
@dseguin dseguin merged commit 93d1f4a into CleverRaven:master Jun 29, 2023
@RenechCDDA
Copy link
Member

Obsoletes #59972 I believe.

@irwiss irwiss deleted the mod_tracker-in-vpart_info branch June 29, 2023 13:50
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants