Call set_language even when LOCALIZE is off #66460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
Test failure unrelated. |
This was causing a frankly hilarious bug that would cause Name::get to return "Tom" no matter what search flags were passed whenever localization was disabled. This meant that EVERYTHING was Tom. Have you been to Tom Town yet? No? That's because it's also called Tom Tom. Can't remember that person's name? It's Tom. Their last name? Also Tom. Committing some identity theft but stuck on "Mother's maiden name"? I'll give you a hint: it's Tom. This commit should fix this disastrous issue by making sure set_language, which is what loads the names file initially, gets called even when localization is disabled.
perryprog
force-pushed
the
tom-tom-tom-tom-tom-tom
branch
from
02448fe to
21e1ec7
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #65640.
Describe the solution
Make sure
set_languagegets called even if localization is disabled, as that calls out toreload_names, andNames::gethas a failsafe of "Tom" for when it doesn't have any names to generate from.Describe alternatives you've considered
Leave in this feature as a mod. Cataclysm: Tom Days Ahead.
Testing
Compiled with localization off and started created a world without being told it should be called "Tom".
Additional context