-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few new child notes and video snippets. #65085
a few new child notes and video snippets. #65085
Conversation
test failure is related to json not changed by this PR |
This is some well written stuff. Good job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured out why your tests were failing.
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
* adds some new snipits. * adds a new snipit. * adds more snippits. * adds more snippits. * adds the Mi-go voice line. * Fixes some, honestly, quite silly buggs. * fixes space and "..." errors. * adds more missing spaces. * nails the last of the missing spaces. I hope.
Summary
Content "Adds a collection of new snippets, both child notes and E-logs."
Purpose of change
More variety in present snippets.
Describe the solution
Adds 10 new snippets: 2 child notes and 8 e-logs, with the latter being quite sizable.
Describe alternatives you've considered
Not adding anything, or trying to keep the snippets shorter, the latter of which I have already tried to do to the best of my ability without jeopardizing the meaning behind the snipits.
Testing
They’re simple text additions.
Additional context