Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make elephant gun a double rifle to match reality #64674

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

Terrorforge
Copy link
Contributor

@Terrorforge Terrorforge commented Mar 29, 2023

Summary

Bugfixes "Make elephant gun a double rifle to match reality"

Purpose of change

After a recent Reddit post reminded me that the elephant gun exists (and is kind of an interesting option now that .50 cal is much harder to get), I got curious and looked up what a .700 NX elephant gun actually looks like, and it turned out that every single example I could find was not single-shot like the in-game item, but a two-barreled double rifle.

Describe the solution

I'm updating the in-game weapon to be a two-shot double rifle. Curiously, the weight and other stats already seem to match. Note that these all seem to be handmade custom guns so they're all going to be slightly different, but the current stats are in the right range.

References:
Auction listing at Rock Island Auction Company with some stats and measurements
Long-winded article with lots of pictures from Revivaler
History of the round and rifles from American Rifleman
Short video of someone shooting one

In addition to increasing magazine size, I made the reload speed faster. I understand that it's probably a bit slow and awkward to reload just because of the weight, but ~6 seconds seemed a bit steep, especially considering it's a break-action where you can quite quickly load two rounds at once. At 2:52 in this video, we can see the guy very unhurriedly reloading one barrel in about 7 seconds. He could certainly do it faster under time pressure, and reloading the other barrel as well wouldn't be that much slower. I don't think there's a good mechanism for making a full reload faster per cartridge than a partial reload, so I've put it at a compromise rate of 300 moves, which probably makes reloading a single barrel slightly faster than it should be, but reloading 2 slightly slower, especially considering rummaging times.

Describe alternatives you've considered

The id trex_gun suggests this was originally intended to be chambered in .577 Tyrannosaur, so I could've reverted it to that. But it turns out the only gun that uses that uses that round, the A-Square T-REX, isn't single-shot either (it's a 3+1 internal magazine bolt action), and the changes required would essentially involve making a whole new gun and cartridge from scratch, which seems unnecessary.

Testing

Spawned the gun and some ammo, checked that it shoots and reloads and all that.

Additional context

I hemmed and hawed over whether or not I should give it the double barrel shotgun's ability to fire both barrels simultaneously. While this would technically be possible, considering what can happen when you do that even with significantly less powerful .500 NX, I've deemed it too impractical to include. Even ignoring the fact that it risks knocking the shooter clean off their feet, it's not clear if the gun itelf could handle it without breaking. While it might indeed be doable by a highly trained shooter or sufficiently beefy mutant, we don't have mechanics for breaking the shoulders and buttstocks of anyone else who tries, so I've elected to simply disallow it.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 29, 2023
@CansecoGPC
Copy link
Contributor

There are examples off real life single barrel chambered with .700 ammo, like these rifles:

Hunting rifles at a convention in 2014
More examples on a nitro express dedicated forum

Maybe it would be better to add the double barrel variant instead of removing the single one.

@KheaHyena
Copy link

I thought there would be a mention specifically for the NX, but I don't see it (it's just called Elephant Gun).

There's a few Elephant Guns out there, as already pointed out, with bolt action and such, all single barrel (which may also include the repurposed ones for military and such). And if we really go far in time, we even have Muskets.
Would it be better to specify or add?
Or just simplify, should the desire for only one Elephant Gun to exist?

@Terrorforge
Copy link
Contributor Author

That second rifle is a bolt action with a three-round magzine. The first does seem to be a falling block single-shot, but I can find no further information about it.

This strikes me as the exception that proves the rule. Single shot .700 guns exist, but you have to go (even further) out of your way to find one.

And perhaps more importantly, I can't find stats for one, so I'm unable to verify if the length, weight etc. is appropriate. I can't find footage of one in use, so it's hard to estimate reload time. All in all, I think it still makes more sense for the default elephant gun to be a double rifle, if for no other reason than because it's easier to compare against reality

@KheaHyena
Copy link

That second rifle is a bolt action with a three-round magzine. The first does seem to be a falling block single-shot, but I can find no further information about it.

This strikes me as the exception that proves the rule. Single shot .700 guns exist, but you have to go (even further) out of your way to find one.

And perhaps more importantly, I can't find stats for one, so I'm unable to verify if the length, weight etc. is appropriate. I can't find footage of one in use, so it's hard to estimate reload time. All in all, I think it still makes more sense for the default elephant gun to be a double rifle, if for no other reason than because it's easier to compare against reality

Yeah, I understand your point, more than valid! I do agree that going for a common version, that's also easier to evaluate stats, to fit best overall.

@CansecoGPC
Copy link
Contributor

That single barrel is harder to find on the internet doesn't make it a exception. I just did a basic search, i'm sure specs and more examples can be found, like this one.

Single barrel bolt action rifle with cartridge 700 NX video

The same video shows a double barrel with no cartridge, just two shots like a shotgun

@CansecoGPC
Copy link
Contributor

CansecoGPC commented Mar 30, 2023

Found some single shot rifles on the photos i posted with specs

700 NE Hambrusch Hunting Weapons

@Terrorforge
Copy link
Contributor Author

Oh, I just realized you're saying "single-barrel" and I'm saying "single-shot". The gun as it currently exists in the game is specifically single-shot, and that's the variant that seems rarest and that I'm having trouble sourcing any information about. I still think the double rifle should be the standard version, but the Hambrusch bolt-action seems well-documented enough that it could be implemented.

That's a bit out of scope for this PR, though. I'm just making a small edit to make the existing elephant gun more closely match the most easily verifiable real-world version.

@Terrorforge
Copy link
Contributor Author

Found some single shot rifles on the photos i posted with specs

700 NE Hambrusch Hunting Weapons

The specs at the bottom seem to be for the bolt-action. Hard to tell, though, because the layout of that page isn't great.

@CansecoGPC
Copy link
Contributor

Found some single shot rifles on the photos i posted with specs
700 NE Hambrusch Hunting Weapons

The specs at the bottom seem to be for the bolt-action. Hard to tell, though, because the layout of that page isn't great.

Yes, it's the bolt action one. Welcome to the 90s web "design", :)

Maybe the name could be changed to "Elephant Double Rifle" or something like that so it's more easy to add the bolt action one with cartridge in the future.

@kevingranade kevingranade merged commit 451f26b into CleverRaven:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants