Fix inventory overwrite #6362
Merged
Fix inventory overwrite #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray for last minute fixes! |
|
Since I don't see Rivet assigned... ;-) |
| mvwputch(w_inv, cur_line, 0, (cur_it == selected ? selected_line_color : c_white), invlet); | ||
| mvwprintz(w_inv, cur_line, 1, (cur_it == selected ? selected_line_color : it.color_in_inventory()), | ||
| _(" %s"), it.display_name().c_str()); | ||
| const int item_max_width = 42; |
There was a problem hiding this comment.
Unused variable warning, courtesy of Code::Blocks. (Compiled, but You've Been Warned. O_O )
|
Gonna go ahead and merge this, easy enough to scrap that line if Jenkins doesn't like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was wrong about curses having a truncation-friendly print method, so I just truncated the string manually. Unfortunately this will not work with multibyte characters, need a dumb truncation method, the ones we have now are too smart and fold instead of truncating. If they are multibyte it'll truncate a little early, which isn't the end of the world.
The underlying problem is the menu isn't split into separate windows, if it were I think It'd truncate automatically.
Candidate for 0.A
Easy reproduction is spawn contained non-drowsy cough syrup and look at your inventory as mentioned in #6358