Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-lethal scratches #62873

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Non-lethal scratches #62873

merged 2 commits into from
Feb 25, 2023

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Balance "Non-lethal scratches"

Purpose of change

Describe the solution

Don't apply scratch damage if this damage will kill monster, player, or his mount. This is applicable only on mundane move through sources of such damage (such as window frames or rose bushes).
Also don't kill monsters moving through rough terrain.

Describe alternatives you've considered

None.

Testing

Made myself a zombie with just 1 point of HP left. Made him step on rose bushes. Watched him not dying from scratches.

Additional context

This will make some tactics (such as waiting until all prisoners die on barbed wires in island prison before going out) no longer viable, but monsters and player dying from a last single scratch of a bush's thorn looks like a more serious problem.

@Night-Pryanik Night-Pryanik added Game: Balance Balancing of (existing) in-game features. Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mechanics: Character / Player Character / Player mechanics labels Dec 25, 2022
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 25, 2022
@Shodan14
Copy link

What about stuff like metal wreckage and whatnot that could in theory kill them?

@NetSysFire
Copy link
Member

You can be killed by everything in theory. But I think the bleeding from said scratches will still get them.

@Night-Pryanik
Copy link
Contributor Author

Everything that has the SHARP flag, including metal wreckage, won't deal direct fatal damage anymore.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 31, 2022
@kevingranade kevingranade merged commit 1d08158 into CleverRaven:master Feb 25, 2023
@Alm999
Copy link
Contributor

Alm999 commented Feb 25, 2023

Thank God!
I was so sick of spiders in their dens casually killing themselves on bushes and turning into much nastier amalgamations!

@Night-Pryanik Night-Pryanik deleted the non-lethal-scratches branch February 26, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions Mechanics: Character / Player Character / Player mechanics Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass Zombie Suicide due to Damaging Tiles
5 participants