Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skatepark ramps #58723

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Skatepark ramps #58723

merged 5 commits into from
Jun 28, 2022

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

Content "Updates skate parks"

Purpose of change

Continues regional terrain project.

Skate parks haven't been updated in 4 years.

Describe the solution

Completely overhauled the skatepark location. Added a new variant with ramp tiles that are supposed represent half-pipes.

Describe alternatives you've considered

Adding skateboards, BMX bikes, or kick scooters.

Testing

Debug-spawned the two skate park variants. The ramps work correctly, and zombies and loot spawn as expected.

Additional context

Screenshots:

kép

kép

kép

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 25, 2022
@descan
Copy link
Contributor

descan commented Jun 26, 2022

... Can you still add the skateboards, BMX bikes, and/or kick scooters? Those sound... Useful.

@LovamKicsiGazsii
Copy link
Contributor Author

... Can you still add the skateboards, BMX bikes, and/or kick scooters? Those sound... Useful.

I lack the C++ knowledge to do that.

@ZhilkinSerg ZhilkinSerg merged commit 76d3bd5 into CleverRaven:master Jun 28, 2022
@LovamKicsiGazsii LovamKicsiGazsii deleted the skatepark branch June 28, 2022 16:28
Drew4484 pushed a commit to Drew4484/Cataclysm-DDA that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants