Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIRE_CONTAINER flag from 'f_oven' #58070

Closed
wants to merge 4 commits into from
Closed

Remove FIRE_CONTAINER flag from 'f_oven' #58070

wants to merge 4 commits into from

Conversation

Ezrashaw
Copy link
Contributor

@Ezrashaw Ezrashaw commented Jun 1, 2022

Summary

None

Purpose of change

Fixes #56343
Removes FIRE_CONTAINER flag from 'f_oven' due to the fact that electric ovens can't realistically contain fire.

Describe the solution

Describe alternatives you've considered

None

Testing

It builds and runs :P

Additional context

Nothing

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Jun 1, 2022
@John-Candlebury
Copy link
Member

John-Candlebury commented Jun 1, 2022

I feel like such a far reaching balance adjustment might require some stronger justification on the "realistically cant contain a fire" part?

@Inglonias
Copy link
Contributor

Inglonias commented Jun 1, 2022

If you do this, you also need to remove the associated tip from the main menu. We don't want to encourage dangerous behavior like that for new players.

@Inglonias
Copy link
Contributor

Inglonias commented Jun 1, 2022

I feel like such a far reaching balance adjustment might require some stronger justification on the "realistically cant contain a fire" part?

Given that most manufacturers suggest avoiding fire in your oven if at all possible, I'm not sure how safe this is realistically.

From a gameplay balance perspective, this is not that big a problem. The biggest problem we'd encounter is older players not realizing this change happened and accidentally setting their house on fire. You can take an oven apart and make a brazier to safely contain fire with a hammer and Fabrication 1, which can be trained trivially on day 1.

@batekulve
Copy link
Contributor

While it's certainly not recommended, I don't see why a fire wouldn't be contained. It's just a metal box with insulation already installed around it.

@Maleclypse
Copy link
Member

It seems likely that ovens contain when food catches on fire but may struggle to contain an intentional fire. Google search attached.

6E6F3A53-37D9-43C4-845F-06407A69A0A5

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 1, 2022
@Ezrashaw
Copy link
Contributor Author

Ezrashaw commented Jun 1, 2022

If you do this, you also need to remove the associated tip from the main menu. We don't want to encourage dangerous behavior like that for new players.

Done! Thanks for that.

Setting logs on fire in an oven would not only damage the electric heating elements and render it unusable, but it would also risk burning through the thin sheet metal bottom of the oven.

From #56343, also agrees with the "can't contain intentional fire" rationale. Maybe some other changes are also necessary to make this work realistically but the concept is correct.

data/core/tips.json Outdated Show resolved Hide resolved
Co-authored-by: Inglonias <2125926+Inglonias@users.noreply.github.com>
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 2, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 5, 2022
@anothersimulacrum
Copy link
Member

Some previous discussion about oven fires: #56807 (comment)

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jul 10, 2022
@Night-Pryanik Night-Pryanik removed the stale Closed for lack of activity, but still valid. label Jul 10, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 13, 2022
@I-am-Erk
Copy link
Member

While I want to see this change, I think it needs to be done in a more complex way, as discussed in the linked issue. I am closing this PR but that doesn't mean it's not wanted, if you would like to revive it you can either ask for this one to be reopened, or start a new one that addresses the concerns.

@I-am-Erk I-am-Erk closed this Nov 24, 2022
@Ezrashaw Ezrashaw deleted the local branch June 9, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FIRE_CONTAINER from oven furniture definition
8 participants