-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FIRE_CONTAINER flag from 'f_oven' #58070
Conversation
I feel like such a far reaching balance adjustment might require some stronger justification on the "realistically cant contain a fire" part? |
If you do this, you also need to remove the associated tip from the main menu. We don't want to encourage dangerous behavior like that for new players. |
Given that most manufacturers suggest avoiding fire in your oven if at all possible, I'm not sure how safe this is realistically. From a gameplay balance perspective, this is not that big a problem. The biggest problem we'd encounter is older players not realizing this change happened and accidentally setting their house on fire. You can take an oven apart and make a brazier to safely contain fire with a hammer and Fabrication 1, which can be trained trivially on day 1. |
While it's certainly not recommended, I don't see why a fire wouldn't be contained. It's just a metal box with insulation already installed around it. |
Done! Thanks for that.
From #56343, also agrees with the "can't contain intentional fire" rationale. Maybe some other changes are also necessary to make this work realistically but the concept is correct. |
Co-authored-by: Inglonias <2125926+Inglonias@users.noreply.github.com>
Some previous discussion about oven fires: #56807 (comment) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
While I want to see this change, I think it needs to be done in a more complex way, as discussed in the linked issue. I am closing this PR but that doesn't mean it's not wanted, if you would like to revive it you can either ask for this one to be reopened, or start a new one that addresses the concerns. |
Summary
None
Purpose of change
Fixes #56343
Removes FIRE_CONTAINER flag from 'f_oven' due to the fact that electric ovens can't realistically contain fire.
Describe the solution
Describe alternatives you've considered
None
Testing
It builds and runs :P
Additional context
Nothing