Don't treat movement noises as provocative #56616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Stop zombies from smashing based on footsteps"
Purpose of change
Some testing indicated that the scourge of zombie bash parties had returned, after some quick investigation the primary cause seems to be that in #44751 "movement" was set to count as provocative, which can sometimes sustain zombie smashing, and looking over what sounds count as "movement" it's the wrong thing to do anyway.
Describe the solution
Adjusted sounds::is_provocative() to return false for movement.
Describe alternatives you've considered
Remove the whole provocative thing entirely? But I think it's anice thing to have even at a reduced scope, talking will give you away and trigger an aggressive response.
Testing
Debug invisibility and no scent, spawn a vehicle, spawn a bunch of zombies. Smash the vehicle to attract the zombies.
Before this change zombies would aggro at other zombies walking around and smash the vehicle, afterwards they remain calm unless they see or smell the player.