Prevent possible nullptr crash #56405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
[C++]
github-actions
bot
added
json-styled
NetSysFire
reviewed
Mar 27, 2022
NetSysFire
added
Info / User Interface
github-actions
bot
added
the
BasicBuildPassed
Co-authored-by: NetSysFire <59517351+NetSysFire@users.noreply.github.com>
Co-authored-by: NetSysFire <59517351+NetSysFire@users.noreply.github.com>
Closed
|
I'm curious what it was about shoulder straps in particular that causes this to happen. Is it because shoulder straps aren't technically armor? We don't explicitly check for nullptr elsewhere in this method, so it might be worth tweaking it just to make the code fit in a little better. |
|
@Inglonias The call to |
mscottnelson
pushed a commit
to mscottnelson/Cataclysm-DDA
that referenced
this pull request
Mar 31, 2022
Co-authored-by: NetSysFire <59517351+NetSysFire@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Prevent possible nullptr crash"
Purpose of change
Fixes #56382
Fixes #56389
Describe the solution
A pointer that can be a nullptr was being referenced, causing a crash when viewing a shoulder strap mod or its recipe. This avoids the use of the pointer when nullptr - behaviour is the same as in other sections of code that use the same pointer.
Describe alternatives you've considered
Testing
Viewing the recipe or shoulder strap item causes no problems. Viewed all recipes with no crashes.
Additional context