Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix food plurals + minor typos #56255

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Fix some errors spotted in Transifex.

Describe the solution

  • Change Pinot noir name to uppercase to match other grapes (Chardonnay and Cabernet Sauvignon).
  • Remove empty spaces at the beginning of 2 descriptions.
  • Replace \ signs to " in some descriptions.
  • Fix name of insect eggs (it doesn't seem to appear in debug menu, but appears in Transifex)
  • Change description of rehydrated eggs to indicate it's plural.
  • Add scoop to frozen yogurt to match other ice creams.
  • Add plurals to missing hot dogs-alike.
  • Fix New England in developer notes (comments).
  • Add space between THC and % symbol.
  • Replace Ö to ö in töttchen dish.
  • Add description for gellatn (it wasn't present in Added Gelatin and Several Gelatin Based Recipes #47080 when it was added so I improvised).
  • Fix plural for canned beans.

Describe alternatives you've considered

  • Write Töttchen instead of töttchen.
  • Replace ö to o in töttchen's desctipion.
  • Don't add space between THC and % (no idea why it wasn't there).
  • Don't change \ to " (is it supposed to be an italic? Weird quote mark?).
  • Look for more errors and or make a bigger PR.

Testing

Compiles fine, changes can be seen in debug menu by spawning items in question.

Additional context

Fixes some Transifex issues.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 20, 2022
Faalagorn and others added 2 commits March 20, 2022 20:19
Co-authored-by: haveric <breuerryan@gmail.com>
Co-authored-by: haveric <breuerryan@gmail.com>
Co-authored-by: haveric <breuerryan@gmail.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 20, 2022
@ZhilkinSerg ZhilkinSerg merged commit ee6697c into CleverRaven:master Mar 22, 2022
@Faalagorn Faalagorn deleted the foodplurals branch March 22, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants