Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make firearm/small repair kit use same batteries as soldering iron #53381

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

TheDarkMaster13
Copy link
Contributor

Summary

Bugfixes "Changed firearm repair kit battery type match soldering iron"

Purpose of change

A firearm repair kit is built using only one electronic device, a soldering iron. This takes light batteries, however the resulting repair kit takes medium batteries. This doesn't make sense.

Describe the solution

The firearm repair kit battery type and default battery has been changed to match the soldering iron.

Describe alternatives you've considered

Changing the soldering iron to use medium batteries instead.

Testing

None, data was copied directly from the soldering iron and should work fine.

Additional context

@wapcaplet wapcaplet added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 11, 2021
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 12, 2021
@TheDarkMaster13
Copy link
Contributor Author

Tested on my end with the latest experimental. Game launched successfully and a spawned firearm repair kit worked as expected.

@I-am-Erk
Copy link
Member

Tests need a swift kick and I can't do it from phone. Would appreciate helps

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 18, 2021
@kevingranade kevingranade merged commit b976332 into CleverRaven:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants