-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple implementation of variables for the pharmacological expansion #53187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Dec 4, 2021
BrettDong
added
Mechanics: Character / Player
Character / Player mechanics
[C++]
Changes (can be) made in C++. Previously named `Code`
labels
Dec 4, 2021
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Dec 4, 2021
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Dec 4, 2021
@Venera3 will want to look at this with me |
How much do you think should fit into this single PR? As far I can see this can probably be merged after sorting out the heart rate modifiers, and separate PRs could be created with the harmful effects for low/high values of these variables as well as the effects of medication/drugs on them. |
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Dec 4, 2021
Seems interesting! This will definitely make things more realistic |
Moved all functions to character_body.cpp, removed health effects on HR, changed cardiac output functionality to represent blood pressure.
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Dec 16, 2021
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Dec 16, 2021
I-am-Erk
reviewed
Dec 16, 2021
I-am-Erk
reviewed
Dec 16, 2021
Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
…ataclysm-DDA into HealthStats_branch
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Character / Player
Character / Player mechanics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Implements basic variables for the pharmacological expansion"
Purpose of change
Adds some of the basic variables required to make #53152 work.
Describe the solution
As of yet I've implemented the code scaffolding required for the variables.
Additionally, I've used code from the existing heart_rate function to create some simple modifiers affecting heart rate.
Balancing WIP.
Describe alternatives you've considered
Not doing this.
Testing
Some basic testing was done to ensure all functions worked properly, using debugmsg() to display the values.
Additional context
Should the Heart Rate index calculations be as complicated? The original issue mentioned that these variables should initially be influenced solely by the consumption of drugs, but the presence of a well thought out heart_rate function in the code that depended on many factors made me reconsider this, as adapting it to work for heart rate index made sense. I'm especially looking for @I-am-Erk's thoughts on this.