Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple implementation of variables for the pharmacological expansion #53187

Merged
merged 14 commits into from
Dec 17, 2021

Conversation

gkarfakis19
Copy link
Contributor

@gkarfakis19 gkarfakis19 commented Dec 4, 2021

Summary

Features "Implements basic variables for the pharmacological expansion"

Purpose of change

Adds some of the basic variables required to make #53152 work.

Describe the solution

As of yet I've implemented the code scaffolding required for the variables.
Additionally, I've used code from the existing heart_rate function to create some simple modifiers affecting heart rate.
Balancing WIP.

Describe alternatives you've considered

Not doing this.

Testing

Some basic testing was done to ensure all functions worked properly, using debugmsg() to display the values.

Additional context

Should the Heart Rate index calculations be as complicated? The original issue mentioned that these variables should initially be influenced solely by the consumption of drugs, but the presence of a well thought out heart_rate function in the code that depended on many factors made me reconsider this, as adapting it to work for heart rate index made sense. I'm especially looking for @I-am-Erk's thoughts on this.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 4, 2021
@BrettDong BrettDong added Mechanics: Character / Player Character / Player mechanics [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 4, 2021
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 4, 2021
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 4, 2021
@I-am-Erk I-am-Erk assigned I-am-Erk and unassigned I-am-Erk Dec 4, 2021
@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 4, 2021

@Venera3 will want to look at this with me

@gkarfakis19
Copy link
Contributor Author

How much do you think should fit into this single PR? As far I can see this can probably be merged after sorting out the heart rate modifiers, and separate PRs could be created with the harmful effects for low/high values of these variables as well as the effects of medication/drugs on them.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 4, 2021
@fungamer2-2
Copy link
Contributor

Seems interesting! This will definitely make things more realistic

Moved all functions to character_body.cpp, removed health effects on HR, changed cardiac output functionality to represent blood pressure.
@gkarfakis19 gkarfakis19 marked this pull request as ready for review December 15, 2021 22:07
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 16, 2021
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 16, 2021
src/character_body.cpp Outdated Show resolved Hide resolved
src/character_body.cpp Outdated Show resolved Hide resolved
@I-am-Erk I-am-Erk merged commit c6e025a into CleverRaven:master Dec 17, 2021
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 17, 2021
@gkarfakis19 gkarfakis19 deleted the HealthStats_branch branch December 20, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants