Freshwater research station roof map added #51323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
|
https://dev.narc.ro/cataclysm/format.html you can lint your json files here. |
I did. I'm not sure what the problem with that file is. Doublechecking... |
Checker didn't like a stray blank line I missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes buggy auto-generation of freshwater research station roof"
Purpose of change
Fixes #50998
Creates dedicated roof map to fix the roof hole issue.
Describe the solution
Created new sub-map for roof, specialized associated palette added to "underwater_structures_palette.json" for future use, adjusted "specials.json" and "overmap_terrain_public_institutional.json" to allow generation of roof when spawned.
Does not fix existing spawns, unfortunately, whether the local maps have been generated or not.
Does allow manual addition of roof maps using debug menu by adding terrain (possibly overwrite of special as well).
Describe alternatives you've considered
Fixing the roof auto-generation where a roof is not defined or fails to spawn correctly. But I have no idea how.
Testing
Altered all four files locally, tested with two pre-existing spawns and manually created all four directional spawns. All spawned correctly. Manually adding roofs to existing spawns via debug also worked correctly.
Additional context