Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change recipe sort to difficulty, name, crafting time #49762

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

Presently the recipes in the crafting menu are sorted by their difficulty factor, which makes the sort order seem completely random, seeing how the factor isn't exposed to the player at all. That would've made some sense had the only way to learn recipes been by practicing the relevant skills, but this is not the case. This PR changes the sort order to alphabetical, making it easier to keep track of what items you can craft.
Implements changes outlined in #47994

Describe the solution

Sort on recipe difficulty first, but when those are the same sort on name, then as a final tie breaker sort on crafting time.

Describe alternatives you've considered

eh

Testing

Entered crafting screen with many recipes unlocked and navigated around a bit to verify that recipes were sorting as expected.

@anothersimulacrum anothersimulacrum added [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. labels Jul 9, 2021
@I-am-Erk
Copy link
Member

I-am-Erk commented Jul 9, 2021

Sort on recipe difficulty first, but when those are the same sort on name, then as a final tie breaker sort on crafting time.

It sounded like you intended to sort by name first, then difficulty? Given that you just explained that sorting by difficulty appears arbitrary

src/crafting_gui.cpp Outdated Show resolved Hide resolved
@Musteval
Copy link
Contributor

Musteval commented Jul 9, 2021

Sort on recipe difficulty first, but when those are the same sort on name, then as a final tie breaker sort on crafting time.

It sounded like you intended to sort by name first, then difficulty? Given that you just explained that sorting by difficulty appears arbitrary

As discussed on the earlier PR #47994 (comment), I consider the fact that difficulty is the first thing we sort on to be a feature rather than a bug - it helps a lot when you're using crafting to train your skills. Definitely agree that within a given difficulty level we should be sorting by name rather than arbitrarily.

Co-authored-by: Saicchi <47158232+Saicchi@users.noreply.github.com>
@kevingranade
Copy link
Member Author

Everything sorted by difficulty ends up fairly incoherent, but grouping by difficulty and then sorting by name ends up pretty good.

@I-am-Erk I-am-Erk merged commit afdc706 into CleverRaven:master Jul 10, 2021
@actual-nh actual-nh added the Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA label Aug 11, 2021
ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants