Roof and general improvements for orchard_apple #49596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o palettes to encompass the buildings and general orchard. Changed the road layout to make it look slightly more natural.
anothersimulacrum
added
[JSON]
curstwist
reviewed
Jul 5, 2021
data/json/mapgen/orchard_apple.json
Outdated
| "palettes": [ "roof_palette" ], | ||
| "nested": { | ||
| "6": { | ||
| "chunks": [ [ "null", 30 ], [ "roof_4x4_holdout", 40 ], [ "roof_5x5_coop", 40 ] ] |
There was a problem hiding this comment.
For nested chunks with larger items like the coop and holdout, make sure there's logical roof access via a ladder or stairs.
curstwist
reviewed
Jul 5, 2021
| "type": "palette", | ||
| "id": "orchard_tree_apple", | ||
| "terrain": { | ||
| " ": [ "t_dirt", "t_grass_long", "t_grass_long", "t_grass", "t_grass", "t_grass", "t_grass" ], |
There was a problem hiding this comment.
We have a more compact way to weight tiles now. Format the array like this: " ": [ [ "t_grass", 4 ], [ "t_grass_long", 2 ], "t_dirt" ], Applies for your other arrays too.
actual-nh
added
0.F Backport Candidate
<Bugfix>
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds a roof to orchard_apple"
Purpose of change
Added a roof to the orchard_apple special along with general improvements. Resolves #49575.
Describe the solution
Basic roof added along with item spawns and a new forklift spawn. Moved the terrain/furniture to a palette file for easier future modification. Changed the road layout to make it look slightly more natural. Removed two vehicle spawns to make room for modified road. Added more specific item groups for the orchard rather than the more generic farming_tools.
Describe alternatives you've considered
An OMT could be added between orchard_processing and orchard_still and the road connection moved to this to make it smoother. Variants featuring other tree types and/or a van serving fruit juice/cider/kompot could be added.
Testing
Ran the adjustments on a clean install.