Made Tea batch crafting mod equal to boiling plain water #49534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Batch-crafting tea is faster than batch-crafting clean water"
Purpose of change
Partially fixes #49362
Describe the solution
Changes Tea(s) batch crafting mod to be the same as boiling to craft clean water.
Describe alternatives you've considered
Making clean water's batch equal to tea
Leaving it as is
Testing
Copied the one file I edited into the most recent experimental build
Checked time display in crafting menu
Test-crafted Pine Tea to confirm
Additional context
Math that made me think this was the best solution (that I was comfortable making):
#49362 (comment)
I personally think the resulting total 50x batch craft time for tea is too long, but I'm not sure whether to change the batch mod to something in-between (dependent on someone doing the math) or to reduce the base crafting time of the teas (though not completely to clean water, considering infusion does take some additional time)