Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Can't cast if Stunned #48651

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

Salty-Panda
Copy link
Contributor

Summary

Mods "[Magiclysm] Can't cast if Stunned"

Purpose of change

After being hit by a riot control platform you can't move in a straight line but can cast high difficulty lighting bolts and teleports?

Describe the solution

Check if the character is stunned before casting a spell if it requires hands
It's a compromise since most mutation spells like Dragon's Breath etc. have this flag and I consider them to be rather instinctual.

Describe alternatives you've considered

Trying to decide what spells are "instinctual" vs "trained"

Testing

Can't cast a spell if stunned
Can use magic items
Can cast a no-hands spell

@actual-nh actual-nh requested a review from KorGgenT April 25, 2021 18:18
@actual-nh actual-nh added 0.F Feature Freeze <Bugfix> This is a fix for a bug (or closes open issue) Mods: Magiclysm Anything to do with the Magiclysm mod labels Apr 25, 2021
@Salty-Panda Salty-Panda changed the base branch from master to 0.F-dev May 3, 2021 15:04
@Salty-Panda Salty-Panda force-pushed the Nerf_spellcasting branch from 6654678 to 23fef74 Compare May 3, 2021 15:04
@ZhilkinSerg ZhilkinSerg force-pushed the 0.F-dev branch 2 times, most recently from 11f8b39 to a3ed94b Compare May 31, 2021 07:49
@ZhilkinSerg ZhilkinSerg force-pushed the 0.F-dev branch 3 times, most recently from ac1984a to c8f13cf Compare June 14, 2021 15:06
@Salty-Panda Salty-Panda requested a review from LyleSY as a code owner June 21, 2021 22:33
@Maleclypse
Copy link
Member

This might be an easy merge if it's rebased onto Master and edited to target master as well.

@Salty-Panda Salty-Panda changed the base branch from 0.F-dev to master July 11, 2021 10:00
@Salty-Panda
Copy link
Contributor Author

Rebased on master, cleared conflicts

@KorGgenT KorGgenT merged commit bc7e4fe into CleverRaven:master Jul 11, 2021
ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Aug 12, 2021
@Salty-Panda Salty-Panda deleted the Nerf_spellcasting branch January 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants