Radioactive fields test allows equality #48121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The radioactive field test is repeatedly failing due to the test being for less-than instead of less-than-or-equal (300 vs 300 turns). Due to test logs not being searchable on either Github or Travis, I am not able to locate some past cases I have seen, but I can locate https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/763202025 and https://github.com/CleverRaven/Cataclysm-DDA/pull/48119/checks?check_run_id=2143797637. (I am grateful to wapcaplet for the PR enabling actually seeing what the numbers were.)
I had been thinking of making all of the less-than turns into less-than-or-equal turns, but decided against it. Some edits were left over; this commit removes them.
wapcaplet
added
the
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The radioactive field test is repeatedly failing due to the test being for less-than instead of less-than-or-equal (300 vs 300 turns). Due to test logs not being searchable on either Github or Travis, I am not able to locate some past cases I have seen, but I can locate https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/763202025 and
https://github.com/CleverRaven/Cataclysm-DDA/pull/48119/checks?check_run_id=2143797637.
Describe the solution
Change < into <= in the radioactive field test comparison. (Also fixes one grammar error.)
Describe alternatives you've considered
I initially had thought of doing this substitution in more of the tests, but decided against it unless similar failures in the others are seen.
Testing
Github and Travis.
Additional context
I am grateful to @wapcaplet for the PR enabling actually seeing what the numbers were. (I suspect that #47512 was another case, for instance, but I don't know for sure without being able to see the numbers.)
Ping: @Aivean, just in case...