New island prison layout #46726

Night-Pryanik · 2021-01-13T19:24:26Z

Summary

Content "New island prison layout."

Purpose of change

While alcatraz island prison layout was fun (I hope), it still was the only one layout for the challenge. So I decided to add a new one.

Describe the solution

Added a new layout. Now with more zombie varieties (and even with named ones!), with underground level, with NPCs, with rudimentary interaction with them, and even with simple mission for them.

Describe alternatives you've considered

Create a nested variant instead of a hand-written one. Maybe next time.

Testing

Debug-spawned location, teleported around to check if everything is fine. Talked to NPCs, accepted and completed mission.

Additional context

Bird-eye view:

North-western part

South-western part

South-eastern part

North-eastern part

Bird-eye view of the underground (huh?)

…f talking

ghost · 2021-01-13T19:31:17Z

data/json/npcs/talk_tags.json

-      "I've had enough of you, begone.",
+      "I've had enough of you, begone",


Are the rest of the insults in this auto-capitalized, thus not needing this to be?

Honestly I'm ambivalent on this. I just needed short insults which could act as a complete sentence, not as a part of some other sentence. But it could be changed to begin with lowercase letters if really needed.

…ryanik/Cataclysm-DDA into new-island-prison-layout

data/json/npcs/island_prison/prisoners.json

Co-authored-by: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>

data/json/npcs/talk_tags.json

actual-nh

Interesting!

data/json/npcs/talk_tags.json

data/json/npcs/factions.json

data/json/scenarios.json

data/json/npcs/island_prison/prisoners.json

data/json/npcs/talk_tags.json

data/json/npcs/island_prison/prisoners.json

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com> Co-authored-by: matskuman5 <selinmatias5@gmail.com>

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>

actual-nh · 2021-01-16T15:47:54Z

data/json/scenarios.json

@@ -377,8 +377,8 @@
    "id": "alcatraz",
    "name": "Challenge - Island Prison",
    "points": -6,
-    "description": "You were at a high-security prison right before the Cataclysm.  You managed to make it outside the inner walls…  Too bad it's located on a remote island, and now you need to find out how to escape it too.",
-    "allowed_locs": [ "sloc_prison_alcatraz" ],
+    "description": "You were in a high-security prison right before the Cataclysm.  Unfortunately, you're still in it, so you need to figure out how to escape.  It's located on a remote island to boot; you'll eventually need to escape that also.",


Suggested change

"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. It's located on a remote island to boot; you'll eventually need to escape that also.",

"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. (It's located on a remote island to boot; you'll eventually need to escape that also.)",

Is this (starting inside) true of the sloc_prison_alcatraz also?

Nope, on alcatraz variant you're starting outside.

Urr. In that case, there really need to be two different descriptions (probably meaning two different Island Prison challenges).

Unfortunately, this is not possible. There could be only one description for the scenario. This is why we need something neutral.
Also it would be very helpful if we could set different scenario descriptions based on scenario professions.

Suggested change

"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. It's located on a remote island to boot; you'll eventually need to escape that also.",

"description": "You were in a high-security prison right before the Cataclysm. You're in a better position to escape than you were before, but you're not there yet. For one thing, it's located on a remote island to boot.",

This would be a convict one.

Suggested change

"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. It's located on a remote island to boot; you'll eventually need to escape that also.",

"description": "You were in a high-security prison right before the Cataclysm. This is a problem, particularly since it's located on a remote island.",

I liked your first variant, and without parentheses.

I like how it reads, but I'm not sure how to adapt it for the Alcatraz setup, or non-prisoner profession.

It's already neutral enough to fit both alcatraz and this setup, and all available professions.

…meets the leader of prisoners

Also many other small tweaks here and there

* Tweaked some things in mapgen palette * Added "prisoner" variants for three zombie types * Added a new "get_lost" talk tag * Added a new "prisoners" faction * Added new NPC class, NPC types with this new class, and a whole lot of talking * Added a new island prison layout and the required stuff for it * Added a new start location in a new prison * Added a case when player already has the id card at the time when he meets the leader of prisoners * Added a small church with a named zombie Co-authored-by: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com> Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com> Co-authored-by: matskuman5 <selinmatias5@gmail.com>

Anton Burmistrov added 7 commits January 13, 2021 23:03

Tweaked some things in mapgen palette

42a3821

Added "prisoner" variants for three zombie types

90303f5

Added a new "get_lost" talk tag

1884e51

Added a new "prisoners" faction

cc9fde7

Added new NPC class, NPC types with this new class, and a whole lot o…

f667fbf

…f talking

Added a new island prison layout and the required stuff for it

8ccf376

Added a new start location in a new prison

bb389a3

Night-Pryanik added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 13, 2021

Merge branch 'master' into new-island-prison-layout

95b2933

ghost reviewed Jan 13, 2021

View reviewed changes

Anton Burmistrov added 3 commits January 14, 2021 00:04

Lint

f34e944

Merge branch 'new-island-prison-layout' of https://github.com/Night-P…

9ed19eb

…ryanik/Cataclysm-DDA into new-island-prison-layout

Lint

65b4678

ghost reviewed Jan 13, 2021

View reviewed changes

data/json/npcs/island_prison/prisoners.json Outdated Show resolved Hide resolved

Update data/json/npcs/island_prison/prisoners.json

e1045b6

Co-authored-by: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>

matskuman5 reviewed Jan 15, 2021

View reviewed changes

data/json/npcs/talk_tags.json Outdated Show resolved Hide resolved

actual-nh reviewed Jan 15, 2021

View reviewed changes

Night-Pryanik commented Jan 15, 2021

View reviewed changes

data/json/npcs/island_prison/prisoners.json Outdated Show resolved Hide resolved

Apply suggestions from code review

3ddf94a

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com> Co-authored-by: matskuman5 <selinmatias5@gmail.com>

actual-nh mentioned this pull request Jan 16, 2021

Test/CI builds (intermittently) failing on field, possibly weary tests (unrelated to pull requests) #46256

Closed

Anton Burmistrov and others added 4 commits January 16, 2021 08:27

Update data/json/scenarios.json

89f30be

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>

Fix error

b1baf1e

Double spaces

9ac3753

Update scenarios.json

c4eb228

actual-nh reviewed Jan 16, 2021

View reviewed changes

Anton Burmistrov added 3 commits January 29, 2021 23:41

Merge branch 'master' into new-island-prison-layout

2a9c1d0

Added a case when player already has the id card at the time when he …

1605c4f

…meets the leader of prisoners

Added a small church with a named zombie

ab268c8

Also many other small tweaks here and there

Night-Pryanik added the 0.F Content Freeze label Feb 3, 2021

kevingranade merged commit 7a5f7e7 into CleverRaven:master Feb 6, 2021

Night-Pryanik deleted the new-island-prison-layout branch February 6, 2021 03:54

Termineitor244 mentioned this pull request Feb 7, 2021

The recently added mission from the new island prison crashes the game at success #47282

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New island prison layout #46726

New island prison layout #46726

Night-Pryanik commented Jan 13, 2021 •

edited

Loading

ghost Jan 13, 2021

Night-Pryanik Jan 13, 2021

actual-nh left a comment

actual-nh Jan 16, 2021

Night-Pryanik Jan 16, 2021

actual-nh Jan 16, 2021

Night-Pryanik Jan 16, 2021

actual-nh Jan 16, 2021 •

edited

Loading

actual-nh Jan 16, 2021

Night-Pryanik Jan 17, 2021

actual-nh Jan 17, 2021

Night-Pryanik Jan 17, 2021

		"I've had enough of you, begone.",
		"I've had enough of you, begone",

	"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. It's located on a remote island to boot; you'll eventually need to escape that also.",
	"description": "You were in a high-security prison right before the Cataclysm. Unfortunately, you're still in it, so you need to figure out how to escape. (It's located on a remote island to boot; you'll eventually need to escape that also.)",

New island prison layout #46726

New island prison layout #46726

Conversation

Night-Pryanik commented Jan 13, 2021 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Choose a reason for hiding this comment

Choose a reason for hiding this comment

actual-nh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

actual-nh Jan 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Night-Pryanik commented Jan 13, 2021 •

edited

Loading

actual-nh Jan 16, 2021 •

edited

Loading