Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json errors in More Locations mod #46337

Merged
merged 7 commits into from
Dec 27, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 26, 2020

Summary

SUMMARY: Bugfixes "Fix json errors in the (hidden) More Locations mod"

Purpose of change

Get rid of the mod test blacklist.

If I understand it correctly, More Locations was marked as obsolete and is supposed to be gradually mainlined. However there doesn't seem to be any update recently, and the recent change to enable json error reports outside the test has caused error messages to show up in old saves that enabled the mod.

I fixed the incorrect mapgen keys based on my understanding of the mapgen template. Some of the incorrect keys did not make much sense given the current mapgen palettes, but I tried my best to guess what the original intention was.

Describe the solution

  1. Remove build-scripts/mod_test_blacklist and update build-scripts/get_all_mods.py and build-scripts/build.sh to enable json check for all mods.
  2. Update the mapgen key error message to be non-fatal, trigger outside of test, and point to the exact string location.
  3. Fix errors reported in the More Locations mod.

Describe alternatives you've considered

Leave the mod be and be annoyed everytime I load the old save.

Testing

Ran the unit test and no warning was reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants