Fix json errors in More Locations mod #46337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix json errors in the (hidden) More Locations mod"
Purpose of change
Get rid of the mod test blacklist.
If I understand it correctly, More Locations was marked as obsolete and is supposed to be gradually mainlined. However there doesn't seem to be any update recently, and the recent change to enable json error reports outside the test has caused error messages to show up in old saves that enabled the mod.
I fixed the incorrect mapgen keys based on my understanding of the mapgen template. Some of the incorrect keys did not make much sense given the current mapgen palettes, but I tried my best to guess what the original intention was.
Describe the solution
build-scripts/mod_test_blacklist
and updatebuild-scripts/get_all_mods.py
andbuild-scripts/build.sh
to enable json check for all mods.Describe alternatives you've considered
Leave the mod be and be annoyed everytime I load the old save.
Testing
Ran the unit test and no warning was reported.