Speedup quicksave (up to x2) by limiting ui_manager::redraw() rate
#45634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aivean
added
[C++]
|
Praise @Aivean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Speedup quicksave (mapbuffer::save) by limiting
ui_manager::redraw()rate"Purpose of change
While profiling auto-/quicksave I noticed that 50% of time is spent in
ui_manager::redraw().Describe the solution
Change the
ui_manager::redraw();invocation to be time-based (every ½ second, similar to waiting/crafting) instead of counter-based.Describe alternatives you've considered
Limit the current counter-based UI refresh rate. Seems like a worse alternative: counter could be tuned only to a single specific scenario (number of submaps that actually need to be saved, submap saving time), while time-based approach always work as designed.
Testing
Manually playtested using quicksave.
Additional context
Profiling:
Before:
After:
Demo:
Before:
After:
