Fix description string extraction #45627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
Reusing needs_plural for extracting plural descriptions was a bad idea - it means that all the item descriptions were erroneously marked as needing plural forms. Add a new category for types neeeding plural descriptions, and use this instead.
anothersimulacrum
force-pushed
the
fix-strings
branch
from
40616d2 to
224c5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Don't add 7000 new unnecessary strings for translation.
Describe the solution
Reusing needs_plural for extracting plural descriptions was a bad idea - it means that all the item descriptions were erroneously marked as needing plural forms.
Add a new category for types neeeding plural descriptions, and use this instead.
Testing
Reviewing
lang/po/cataclysm-dda.potwhen updated with both versions of this show that this does not add plural forms for item descriptions.Also tested live on Transifex (my bad)!
Additional context
This should also fix the flake8 linting issue.