Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance tactical helmets #45584

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Balance tactical helmets #45584

merged 2 commits into from
Jul 6, 2021

Conversation

DericHuynh
Copy link
Contributor

@DericHuynh DericHuynh commented Nov 23, 2020

Summary

SUMMARY: Balance "Balance Tactical Helmets"

Purpose of change

The tactical helmets were essentially useless before. They boasted defensive stats only a 1/3 of the army helmet, while also being relatively rare in comparison. A quick search on google showed that the tactical helmets and army helmets are essentially the same, so I've decided to buff the Tactical helmets in order to make them a viable alternative.

Describe the solution

I balanced the Tactical helmets in terms of weight, volume, encumbrance, and protection value, while also giving them the same flags as the army helmet. This should make the tactical helmets comparable.

Describe alternatives you've considered

I've considered nerfing the army helmet, but reminded myself of the ESAPI vest and decided not to.

Testing

I ran the game and spawned them in to test if the JSON worked.

Balanced the tactical helmets, to make them less useless.
26 seems to little for the protection that it provides, also considering the increased weight of the helmet.
@DericHuynh DericHuynh changed the title Pull Balance tactical helmets Nov 23, 2020
"weight": "1594 g",
"volume": "2250 ml",
"price": 25000,
"price_postapoc": 2500,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is wrong. Sturdy helmets should be one of the first things to seek after the apocalypse, and thus they shouldn't cost mere $25. I'd set the price_postapoc to at least of its pre-apocalypse value, or maybe even raise it a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also while you're at it, make it a string 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, the army helmet was listed as 1500 postapoc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the other items, and it seems that the postapoc pricing is relative. For example, the A7 Laser rifle, a more endgame item is 7500 postapoc, or 75$.

Copy link
Contributor Author

@DericHuynh DericHuynh Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also while you're at it, make it a string 🙏

what do you mean by "make it a string"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a total overhaul of postapoc prices, so we can start with this helmet.

@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. labels Nov 23, 2020
@Kelenius
Copy link
Contributor

A quick search on google showed that the tactical helmets and army helmets are essentially the same

What's the actual difference between them? Maybe they could be simply merged into a single item if they're so similar.

@Zireael07
Copy link
Contributor

@Kelenius: A quick google shows me this:
Screenshot_20201124_135125
Screenshot_20201124_135108

So tactical helmet > army helmet because tactical helmet can include a face protection, while army helmet does not have face protection at all. For CDDA purposes, let's say ALL tac helmets have face protection.

@Kelenius
Copy link
Contributor

@Zireael07

The one covering the face would be tac_fullhelmet, "An all-encompassing black helmet that covers your entire face and neck, providing excellent protection from all sorts of damage.". The game also has tac_helmet, "A lightweight black helmet that provides excellent protection from all sorts of damage." which does not cover the face.

@Zireael07
Copy link
Contributor

In that case, I would indeed merge army helmet and tac_helmet (the one without face protection) into one.

@Rivet-the-Zombie
Copy link
Member

In that case, I would indeed merge army helmet and tac_helmet (the one without face protection) into one.

It would still be good to keep separate items - even if one's stats are just copied directly from the other - so that the stuff like the various police professions and zombies don't suddenly start showing up wearing army helmets.

@stale
Copy link

stale bot commented Dec 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 28, 2020
@Night-Pryanik Night-Pryanik removed the stale Closed for lack of activity, but still valid. label Jan 25, 2021
@I-am-Erk I-am-Erk merged commit c8d50bb into CleverRaven:master Jul 6, 2021
@actual-nh actual-nh added 0.F Backport Candidate <Bugfix> This is a fix for a bug (or closes open issue) and removed 0.F Content Freeze labels Jul 10, 2021
ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Aug 12, 2021
ZhilkinSerg added a commit that referenced this pull request Aug 14, 2021
@DericHuynh DericHuynh deleted the pull branch September 15, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants