Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalance hot dog and bratwurst recipes. #45513

Merged

Conversation

FeepingCreature
Copy link
Contributor

@FeepingCreature FeepingCreature commented Nov 19, 2020

SUMMARY: Balance "Rebalance hot dog and bratwurst recipes."

  1. Tallow weight was previously halved, but not calories. Fix to be correct.
  2. Hotdog recipe produced too few hotdogs: recalculate from first principles.
  3. Bratwurst recipe produced too many bratwürste: recalculate from first principles.

Hotdog:

meat_nofish is 300-400kcal (comment). This matches meat_red at 300g.
A hotdog weighs (APPROXIMATELY) 80g; hence the recipe should produce ~7 hotdogs for 2 meat_red.
A hotdog weighs 43g (apparently a mini?); hence the recipe should produce
~12 hotdogs for 2 meat_red. Halve the number of sausage casings cause
let's be honest; you're not using a full sausage casing for a 43g sausage.

Bratwurst:

A bratwurst should mix fat to meat at 1:3. Since edible_fat is 220g, edible_tallow_lard (55g) needs to be x4.
This matches the 2 meat_red for 600g and 1:3 ratio.
At 820g total and 100g for the Bratwurst, we get 8 charges out.

Brought to you by ~2 hours of staring at recipe files and frantically googling meat and fat calorie statistics.

@FeepingCreature
Copy link
Contributor Author

FeepingCreature commented Nov 19, 2020

Ah, looks like a bunch of other recipes consume 2 tallow.
Should the original 110g -> 55g change just be reverted?

Please give your opinion!

@wapcaplet wapcaplet added Game: Balance Balancing of (existing) in-game features. Items: Food / Vitamins Comestibles and drinks labels Nov 20, 2020
@FeepingCreature
Copy link
Contributor Author

FeepingCreature commented Nov 21, 2020

Doubled the tallow use in the other food recipes. Let's see if that fixes the testsuite.

edit: The remaining errors seem unrelated.

@FeepingCreature FeepingCreature force-pushed the fix/rebalance-hot-dogs branch 4 times, most recently from 185f3b3 to aec1812 Compare November 21, 2020 16:56
…lved the

weight without adjusting the calories.
To compensate, double use of tallow in every recipe where calories matter.
1. Hotdog recipe produced too few hotdogs: recalculate from first principles.
2. Bratwurst recipe produced too many bratwürste: recalculate from first principles.

Hotdog:

meat_nofish is 300-400kcal (comment). This matches meat_red at 300g.
A hotdog weighs 43g (apparently a mini?); hence the recipe should produce
~12 hotdogs for 2 meat_red. Halve the number of sausage casings cause
let's be honest; you're not using a full sausage casing for a 43g sausage.

Bratwurst:

A bratwurst should mix fat to meat at 1:3. Since edible_fat is 220g, edible_tallow_lard (55g) needs to be x4.
This matches the 2 meat_red for 600g and 1:3 ratio.
At 820g total and 100g for the Bratwurst, we get 8 charges out.
@FeepingCreature
Copy link
Contributor Author

FeepingCreature commented Nov 24, 2020

Quick, merge it while it's mostly green! 😆

@kevingranade kevingranade merged commit feed65f into CleverRaven:master Nov 25, 2020
@FeepingCreature FeepingCreature deleted the fix/rebalance-hot-dogs branch November 25, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. Items: Food / Vitamins Comestibles and drinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants