Fixes activity zone sorting for comestibles in containers.

[Squishums]

Summary

SUMMARY: Bugfixes "Fixes activity zone sorting for comestibles in containers"

Purpose of change

Fixes #44245

This is something that really bothered me as a player, tbh. Using zones and Shift+O to sort items doesn't play nicely with containers, which isn't a problem for most items, since they're usually loose, but comestibles from house scrounging are almost always contained within something. The logic for whether an item is food changed when pockets were added, about 6 months ago.

Describe the solution

Well... just kinda fixed the logic? When sorting comestible containers, consider the contained item, but also account for whether the spoilage rate of the containing pocket. If a container will ever spoil if left out at room temperature, consider it perishable.

Describe alternatives you've considered

Freezing all food so there are no liquids and nothing ever spoils. It could all go on the same tile then. Would make life much simpler.

This cooouuulllldddd be fixed by making changed to get_food to mirror the pre-pocket logic, but without any test coverage I'm not confident it won't break more things than it'll solve. item.cpp desperately needs a refactor. There's logic for weapons, food, clothing, tools, whatever, all in one huge file.

Could expand this to be a general solution for sorting containers but it's not as obvious what the correct behaviour is for non-comestibles. Going to limit the scope here to where it makes the biggest difference.

Finally, I don't think relatively shelf stable comestibles, like lasagne sheets which last a literal year, should be considered perishable for the sorting logic. It's not like you're refrigerating it anyway. Will want to come up with some cutoff threshold in the future.

Testing

Why I added tests of course. The auto sort logic was completely untested, and honestly anything touching either pockets or spoilage is arcane voodoo at best. I also set up an in-game test using a bunch of different item types, which you can see below. Before the change, the two drink zones were completely unused, as all liquids require a container, and the perishable food zone was only filled with perishables outside of a container.

Setup	After Sort (looking at drinks)

Please don't judge my nude shame, I was testing a new clothing feature 😔

Additional context

The pocket spoilage logic really only looks at a item's direct parent for the spoilage rate. It should be really be doing a tree walk to the root pocket and multiplying all the spoilage reductions, but like again, not gonna change that here.

[andrei8l]

I don't think this const_cast does anything here. The method is already marked const so this is const already.

[Squishums]

It's actually casting this to a mutable item * so that we can use the mutable contained_where implementation. We can't call it without the cast, because the mutable version returns a mutable reference, which is a no-go from a const object. It's a common C++ trick to avoid having to duplicate the entire method body for these const/mutable method pairs, and it's safe as long as your mutable version doesn't have side effects.

[andrei8l]

I see; thanks!

[Squishums]

Astyle failure is suffer.cpp, which I didn't touch 🤷‍♀️

[Squishums]

Took some time to get the clang tidy plugin working locally. PR should be good now. Clang Build Analyze failure isn't related.

[Squishums]

The travis build failure is kinda directly contradicting the clang-tidy complaint about wanting the the tripoint to default initialize itself.

What it's complaining about now has been allowed on major compilers for a while now, and particularly on clang since 3.9... unfortunately travis is using 3.8.