Trivial: fix "item description flags" test in Windows builds #45394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aivean
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "fix 'item description flags' test in Windows builds"
Purpose of change
Noticed item info test failure in Windows builds:
screenshot
https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/743318251
This is a fallout from #45099 and #45277 , the test was relying on the lexicographic order of
json_flagids.Describe the solution
Wrap the info generation in
sort_lexto restore the previous behavior.Describe alternatives you've considered
None.
Testing
Run this test locally.