Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class translation for faction description and other translation updates #44691

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Oct 7, 2020

Summary

SUMMARY: I18N "Use class translation for faction description and other translation updates"

Purpose of change

  1. Use class translation for faction description for automatic text style checking.
  2. Convert some old translator comments in json files to use extractable translator comments syntax.
  3. Check for spaces after period and before end of string and fix reported strings.
  4. Update the translation documentation.

Testing

Game loads, and no further issue was reported by the unit test.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Translation I18n NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Oct 7, 2020
@ZhilkinSerg ZhilkinSerg merged commit 40e880e into CleverRaven:master Oct 7, 2020
@Qrox Qrox deleted the translation-8 branch October 8, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants