shadowcasting benchmark #44557
Merged
shadowcasting benchmark #44557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
kevingranade
commented
Oct 4, 2020
kevingranade
commented
Oct 4, 2020
jbytheway
reviewed
Oct 5, 2020
tests/shadowcasting_test.cpp
Outdated
| std::array<const float ( * )[MAPSIZE *SEEX][MAPSIZE *SEEY], OVERMAP_LAYERS> &transparency_caches, | ||
| const int iterations ) | ||
| { | ||
| float seen_squares[OVERMAP_LAYERS][MAPSIZE * SEEX][MAPSIZE * SEEY] = {{{0}}}; |
There was a problem hiding this comment.
Suggested change
| float seen_squares[OVERMAP_LAYERS][MAPSIZE * SEEX][MAPSIZE * SEEY] = {{{0}}}; | |
| float seen_squares[OVERMAP_LAYERS][MAPSIZE * SEEX][MAPSIZE * SEEY] = {}; |
If it looks cleaner to you, you can just initialize these arrays like this and it should be equivalent (and maybe won't cause compiler complaints?).
There was a problem hiding this comment.
Looks good so far, I just hate the implicit-ness of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Better shadowcasting benchamark.
Describe the solution
Added an actual 3D noise benchmark, a benchmark on an open plain, and an open plain with sparse obstacles.
Describe alternatives you've considered
There are innumerable other scenes worth adding.
Testing
It is a test.