Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Rollback of Visual Studio version in Appveyor #43345

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

In #42847 I rolled back the Appveyor VS version because the latest was causing issues.

Now the "previous" version is the one that was problematic.

Describe the solution

Revert the rollback and hope the new version has fixed the issue.

Even if it hasn't, we probably still want to revert this change. Whenever a fix does arrive we'll get it faster.

Describe alternatives you've considered

None

Testing

Needs to be tested here on CI.

Hoping that the new version fixed the issues that caused us to roll
back.

This reverts commit 020914f.
@jbytheway
Copy link
Contributor Author

Hmm... Seems to have gotten even worse

Fetching repository commit (61dbfaf)...OK
Total: 267.6 MB in 4512 files
Restoring build cache
Cache 'c:\tools\vcpkg\installed' - Restored
Running Install scripts
vcpkg --triplet x64-windows-static install sdl2 sdl2-image sdl2-mixer sdl2-ttf gettext
Computing installation plan...
The following packages are already installed:
    gettext[core]:x64-windows-static
    sdl2[core]:x64-windows-static
    sdl2-image[core]:x64-windows-static
    sdl2-ttf[core]:x64-windows-static
The following packages will be rebuilt:
    sdl2-mixer[core,nativemidi]:x64-windows-static
If you are sure you want to rebuild the above packages, run the command with the --recurse option
Command exited with code 1

Anyone know enough Appveyor/vcpkg to understand this? Should we use the --recurse option as it suggests?

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: Windows Issues related to Windows operating system labels Aug 31, 2020
- removed install script (vcpkg packages are handled in VS projects now);
- added new location to cache.
@ZhilkinSerg
Copy link
Contributor

We don't really need vcpkg install script now - packages are handled via VS project files.

@ZhilkinSerg ZhilkinSerg merged commit c3fc83e into CleverRaven:master Aug 31, 2020
@jbytheway jbytheway deleted the revert_appveyor_change branch August 31, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments OS: Windows Issues related to Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants