Achievement completed popup #42829
Merged
Achievement completed popup #42829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Games of a certain age will have a json memorial file containing no game_start event. Currently such files cause a debugmsg, but they shouldn't. Handle that case differently.
Show a popup window when achievements are completed. By default this is shown only when someone gets an achievement that they have not completed in any previous game. But there is an option to either always or never show such popups.
|
Is there a way to make it pop up somewhere on the edge of the screen? Not in the middle. That's how other games usually display achievements. |
|
It's easy to put it at the top, since we already have code for that, but I think it's better to have it in the middle because the player needs to dismiss it. In other games where it appears at the edge of the screen it will go away by itself, but I didn't think a timed popup like that was a good choice for Cata's interface style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Optional popup window when completing achievements"
Purpose of change
Achievements are still not very obvious. In most games, getting an achievement comes with some kind of popup window. We should have something similar.
Describe the solution
Add such a window.
Add a new Interface option to select how often that popup occurs. By default it's every time you get an achievement for the first time (i.e. one you haven't had in a previous game). But you can also select always or never to have it.
At the same time, fixed a bug introduced in #42731 related to loading memorial files from games of a certain age which contain events but no
game_startevent.Describe alternatives you've considered
Would have been nice to have a popup with a title, but I didn't want to make this more complex by adding messy UI code.
I would like a better way to wrap the help text at the bottom of the window (see screenshot below). For now I just hardcoded a newline, but I'd rather it be wrapped to the width of the achievement description. I could have written code to do that, but it seemed like it would be too much code for a very small improvement.
Testing
In-game testing under the default setting.
Additional context
This is a followup to #42731. With this change, I think the achievements system has achieved a minimal complete status where players should not be too confused by it. This is the last feature I'm hoping to get squeezed in before release, despite the feature freeze.