Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gitignore for build-data/osx/AppIcon.icns #42797

Merged
merged 1 commit into from
Aug 8, 2020
Merged

fix gitignore for build-data/osx/AppIcon.icns #42797

merged 1 commit into from
Aug 8, 2020

Conversation

akirashirosawa
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fix path AppIcon.icns for macOS after "osx specific data folder out of shared data folder" (PR #39971)

Describe the solution

--- a/.gitignore
+++ b/.gitignore
@@ -123,7 +123,7 @@ nbproject/
 
 # OSX
 Cataclysm.app
-data/osx/AppIcon.icns
+build-data/osx/AppIcon.icns
 Cataclysm.dmg

Testing

git status
modified: build-data/osx/AppIcon.icns

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system labels Aug 8, 2020
@ZhilkinSerg ZhilkinSerg merged commit 9091137 into CleverRaven:master Aug 8, 2020
@akirashirosawa akirashirosawa deleted the update-gitignore-for-build-data-osx branch August 8, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akirashirosawa @ZhilkinSerg