Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doxygen comments to character.h #42579

Merged
merged 4 commits into from
Jul 31, 2020

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Jul 30, 2020

Summary

SUMMARY: None

Purpose of change

See if I can improve the user friendliness of character header in such a manner that doxygen can read it

Describe the solution

Mostly take the existing doc and just format is slightly differently for doxygen. Add some doc where I can (avoiding stating the obvious).

Describe alternatives you've considered

Some of my comments might be close to stating what is obvious. Stating the obvious is counter-productive; it makes the code less user friendly.

I'm not yet capable enough to doxygenate the entire file. Hopefully piecemeal modifications aren't distracting. FWIW this concern is somewhat lessened because the comments weren't uniform to begin with.

Additional context

This PR isn't seeking to be comprehensive. My main goal is do no harm and not get in the way. Secondary goal is to modestly improve the readability of the code. Also hoping to learn more about how doxygen works and stumble upon something cool it can do.

Jerimee added 2 commits July 30, 2020 18:56
add doxygen formatted comments to some enum
@Jerimee Jerimee changed the title WIP comment character.h doxygen comments to character.h Jul 30, 2020
@anothersimulacrum anothersimulacrum added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` labels Jul 31, 2020
@ZhilkinSerg ZhilkinSerg merged commit 8f77d92 into CleverRaven:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants